2020-03-11 12:21:47

by Walter Wu

Subject: [PATCH] pid: fix uninitialized var warnings

Compiling with gcc-9.2.1 points out below warnings. Fix it.

kernel/pid.c: In function 'alloc_pid':
kernel/pid.c:180:10: warning: 'retval' may be used uninitialized
in this function [-Wmaybe-uninitialized]

Cc: Andrew Morton <[email protected]>
Cc: Christian Brauner <[email protected]>
Cc: Oleg Nesterov <[email protected]>
Signed-off-by: Walter Wu <[email protected]>
---
kernel/pid.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/pid.c b/kernel/pid.c
index ff6cd6786d10..02944cfd4e51 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -176,8 +176,10 @@ struct pid *alloc_pid(struct pid_namespace *ns, pid_t *set_tid,
return ERR_PTR(-EINVAL);

pid = kmem_cache_alloc(ns->pid_cachep, GFP_KERNEL);
- if (!pid)
+ if (!pid) {
+ retval = -ENOMEM;
return ERR_PTR(retval);
+ }

tmp = ns;
pid->level = ns->level;
--
2.18.0

2020-03-11 12:24:49

by Christian Brauner

Subject: Re: [PATCH] pid: fix uninitialized var warnings

On Wed, Mar 11, 2020 at 08:20:49PM +0800, Walter Wu wrote:
> Compiling with gcc-9.2.1 points out below warnings. Fix it.
>
> kernel/pid.c: In function 'alloc_pid':
> kernel/pid.c:180:10: warning: 'retval' may be used uninitialized
> in this function [-Wmaybe-uninitialized]
>
> Cc: Andrew Morton <[email protected]>
> Cc: Christian Brauner <[email protected]>
> Cc: Oleg Nesterov <[email protected]>
> Signed-off-by: Walter Wu <[email protected]>

Thanks. A correct fix for this is already in my tree:
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/commit/?h=fixes&id=10dab84caf400f2f5f8b010ebb0c7c4272ec5093
(Background is
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/commit/?h=fixes&id=b26ebfe12f34f372cf041c6f801fa49c3fb382c5
)

Christian