2020-03-18 17:47:19

by Mateusz Nosek

Subject: [PATCH] mm/compaction.c: Clean code by removing unnecessary assignment

From: Mateusz Nosek <[email protected]>

Previously 0 was assigned to variable 'last_migrated_pfn'. But the
variable is not read after that, so the assignment can be removed.

Signed-off-by: Mateusz Nosek <[email protected]>
---
mm/compaction.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 827d8a2b3164..4576d6c5afb5 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2183,7 +2183,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc)
ret = COMPACT_CONTENDED;
putback_movable_pages(&cc->migratepages);
cc->nr_migratepages = 0;
- last_migrated_pfn = 0;
goto out;
case ISOLATE_NONE:
if (update_cached) {
--
2.17.1

2020-03-20 17:31:32

by Vlastimil Babka

Subject: Re: [PATCH] mm/compaction.c: Clean code by removing unnecessary assignment

On 3/18/20 6:45 PM, [email protected] wrote:
> From: Mateusz Nosek <[email protected]>
>
> Previously 0 was assigned to variable 'last_migrated_pfn'. But the
> variable is not read after that, so the assignment can be removed.
>
> Signed-off-by: Mateusz Nosek <[email protected]>

Acked-by: Vlastimil Babka <[email protected]>

> ---
> mm/compaction.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 827d8a2b3164..4576d6c5afb5 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -2183,7 +2183,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc)
> ret = COMPACT_CONTENDED;
> putback_movable_pages(&cc->migratepages);
> cc->nr_migratepages = 0;
> - last_migrated_pfn = 0;
> goto out;
> case ISOLATE_NONE:
> if (update_cached) {
>