2020-03-16 06:54:56

by Mike Looijmans

Subject: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings

This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
the accelerometer part.

Signed-off-by: Mike Looijmans <[email protected]>
---
.../devicetree/bindings/iio/accel/bmi088.txt | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt

diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
new file mode 100644
index 000000000000..691a47726dbc
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
@@ -0,0 +1,23 @@
+* Bosch BMI088 IMU combining accelerometer and gyroscope
+
+https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
+
+Required properties:
+
+ - compatible : should be "bosch,bmi088_accel"
+ - reg : the I2C address of the sensor or the SPI chip select number
+
+Optional properties:
+
+ - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
+ IRQ_TYPE_EDGE_RISING
+
+Example:
+
+bmi088_accel@1 {
+ compatible = "bosch,bmi088_accel";
+ reg = <1>;
+ spi-max-frequency = <10000000>;
+ interrupt-parent = <&gpio>;
+ interrupts = <90 IRQ_TYPE_EDGE_RISING>;
+};
--
2.17.1

2020-03-22 17:37:43

by Jonathan Cameron

Subject: Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings

On Mon, 16 Mar 2020 07:52:18 +0100
Mike Looijmans <[email protected]> wrote:

> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> the accelerometer part.
>
> Signed-off-by: Mike Looijmans <[email protected]>
> ---
> .../devicetree/bindings/iio/accel/bmi088.txt | 23 +++++++++++++++++++

Sorry. All new DT bindings need to be in yaml format.

Please put this in the same series as the driver.

Thanks,

Jonathan

> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> new file mode 100644
> index 000000000000..691a47726dbc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> @@ -0,0 +1,23 @@
> +* Bosch BMI088 IMU combining accelerometer and gyroscope
> +
> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> +
> +Required properties:
> +
> + - compatible : should be "bosch,bmi088_accel"
> + - reg : the I2C address of the sensor or the SPI chip select number
> +
> +Optional properties:
> +
> + - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
> + IRQ_TYPE_EDGE_RISING
> +
> +Example:
> +
> +bmi088_accel@1 {
> + compatible = "bosch,bmi088_accel";
> + reg = <1>;
> + spi-max-frequency = <10000000>;
> + interrupt-parent = <&gpio>;
> + interrupts = <90 IRQ_TYPE_EDGE_RISING>;
> +};

2020-03-23 09:57:46

by Mike Looijmans

Subject: Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings

On 22-03-2020 18:37, Jonathan Cameron wrote:
> On Mon, 16 Mar 2020 07:52:18 +0100
> Mike Looijmans <[email protected]> wrote:
>
>> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
>> the accelerometer part.
>>
>> Signed-off-by: Mike Looijmans <[email protected]>
>> ---
>> .../devicetree/bindings/iio/accel/bmi088.txt | 23 +++++++++++++++++++
>
> Sorry. All new DT bindings need to be in yaml format.
>
> Please put this in the same series as the driver.

sooy, I noticed this too late, patches are underway in separate mails
now. Hope that isn't a blocking issue?

>
> Thanks,
>
> Jonathan
>
>> 1 file changed, 23 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
>> new file mode 100644
>> index 000000000000..691a47726dbc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
>> @@ -0,0 +1,23 @@
>> +* Bosch BMI088 IMU combining accelerometer and gyroscope
>> +
>> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
>> +
>> +Required properties:
>> +
>> + - compatible : should be "bosch,bmi088_accel"
>> + - reg : the I2C address of the sensor or the SPI chip select number
>> +
>> +Optional properties:
>> +
>> + - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
>> + IRQ_TYPE_EDGE_RISING
>> +
>> +Example:
>> +
>> +bmi088_accel@1 {
>> + compatible = "bosch,bmi088_accel";
>> + reg = <1>;
>> + spi-max-frequency = <10000000>;
>> + interrupt-parent = <&gpio>;
>> + interrupts = <90 IRQ_TYPE_EDGE_RISING>;
>> +};
>


--
Mike Looijmans

2020-03-23 16:43:09

by Jonathan Cameron

Subject: Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings

On Mon, 23 Mar 2020 10:56:41 +0100
Mike Looijmans <[email protected]> wrote:

> On 22-03-2020 18:37, Jonathan Cameron wrote:
> > On Mon, 16 Mar 2020 07:52:18 +0100
> > Mike Looijmans <[email protected]> wrote:
> >
> >> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> >> the accelerometer part.
> >>
> >> Signed-off-by: Mike Looijmans <[email protected]>
> >> ---
> >> .../devicetree/bindings/iio/accel/bmi088.txt | 23 +++++++++++++++++++
> >
> > Sorry. All new DT bindings need to be in yaml format.
> >
> > Please put this in the same series as the driver.
>
> sooy, I noticed this too late, patches are underway in separate mails
> now. Hope that isn't a blocking issue?

For next version of either pull them together.

Jonathan

>
> >
> > Thanks,
> >
> > Jonathan
> >
> >> 1 file changed, 23 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >> new file mode 100644
> >> index 000000000000..691a47726dbc
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >> @@ -0,0 +1,23 @@
> >> +* Bosch BMI088 IMU combining accelerometer and gyroscope
> >> +
> >> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> >> +
> >> +Required properties:
> >> +
> >> + - compatible : should be "bosch,bmi088_accel"
> >> + - reg : the I2C address of the sensor or the SPI chip select number
> >> +
> >> +Optional properties:
> >> +
> >> + - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
> >> + IRQ_TYPE_EDGE_RISING
> >> +
> >> +Example:
> >> +
> >> +bmi088_accel@1 {
> >> + compatible = "bosch,bmi088_accel";
> >> + reg = <1>;
> >> + spi-max-frequency = <10000000>;
> >> + interrupt-parent = <&gpio>;
> >> + interrupts = <90 IRQ_TYPE_EDGE_RISING>;
> >> +};
> >
>
>