2020-03-25 03:33:27

by 罗楚成

Subject: [PATCH] io_uring:fix missing 'return' in comment

the missing 'return' work may make it hard
for other developers to understand it.

Signed-off-by: Chucheng Luo <[email protected]>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 5a826017ebb8..4b971c7b4483 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2379,7 +2379,7 @@ static int io_write(struct io_kiocb *req, struct io_kiocb **nxt,
else
ret2 = loop_rw_iter(WRITE, req->file, kiocb, &iter);
/*
- * Raw bdev writes will -EOPNOTSUPP for IOCB_NOWAIT. Just
+ * Raw bdev writes will return -EOPNOTSUPP for IOCB_NOWAIT. Just
* retry them without IOCB_NOWAIT.
*/
if (ret2 == -EOPNOTSUPP && (kiocb->ki_flags & IOCB_NOWAIT))
--
2.17.1

2020-03-25 03:49:41

by Jens Axboe

Subject: Re: [PATCH] io_uring:fix missing 'return' in comment

On 3/24/20 9:31 PM, Chucheng Luo wrote:
> the missing 'return' work may make it hard
> for other developers to understand it.

Thanks, that does read better. Notes for future patches:

- You should capitalize the first letter in the commit message,
any sentence really.
- Commit messages should use 72-74 chars of line width
- Add a space after 'io_uring:' and title description

I fixed these up and hand applied to for-5.7/io_uring.

--
Jens Axboe