2020-03-28 16:48:01

by George Spelvin

[permalink] [raw]
Subject: [RFC PATCH v1 31/50] lib/nodemask.c: Use cheaper prandom_u32_max() in node_random()

This function is to spread things around uniformly; cryptographic
unguessability is not required.

Signed-off-by: George Spelvin <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Mel Gorman <[email protected]>
---
lib/nodemask.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/nodemask.c b/lib/nodemask.c
index 3aa454c54c0de..330f9c7d3da97 100644
--- a/lib/nodemask.c
+++ b/lib/nodemask.c
@@ -25,7 +25,7 @@ int node_random(const nodemask_t *maskp)
w = nodes_weight(*maskp);
if (w)
bit = bitmap_ord_to_pos(maskp->bits,
- get_random_int() % w, MAX_NUMNODES);
+ prandom_u32_max(w), MAX_NUMNODES);
return bit;
}
#endif
--
2.26.0