2020-03-29 05:50:28

by Rouven Czerwinski

[permalink] [raw]
Subject: [PATCH] ALSA: hda: default enable CA0132 DSP support

From: Rouven Czerwinski <[email protected]>

If SND_HDA_CODEC_CA0132 is enabled, the DSP support should be enabled as
well. Disabled DSP support leads to a hanging alsa system and no sound
output on the card otherwise. Tested on:

06:00.0 Audio device: Creative Labs Sound Core3D [Sound Blaster Recon3D / Z-Series] (rev 01)

Signed-off-by: Rouven Czerwinski <[email protected]>
---
sound/pci/hda/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index bd48335d09d7..e1d3082a4fe9 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -184,6 +184,7 @@ comment "Set to Y if you want auto-loading the codec driver"
config SND_HDA_CODEC_CA0132_DSP
bool "Support new DSP code for CA0132 codec"
depends on SND_HDA_CODEC_CA0132
+ default y
select SND_HDA_DSP_LOADER
select FW_LOADER
help

base-commit: e595dd94515ed6bc5ba38fce0f9598db8c0ee9a9
--
2.25.1


2020-03-29 07:48:00

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] ALSA: hda: default enable CA0132 DSP support

On Sun, 29 Mar 2020 07:30:15 +0200,
Rouven Czerwinski wrote:
>
> From: Rouven Czerwinski <[email protected]>
>
> If SND_HDA_CODEC_CA0132 is enabled, the DSP support should be enabled as
> well. Disabled DSP support leads to a hanging alsa system and no sound
> output on the card otherwise. Tested on:
>
> 06:00.0 Audio device: Creative Labs Sound Core3D [Sound Blaster Recon3D / Z-Series] (rev 01)
>
> Signed-off-by: Rouven Czerwinski <[email protected]>

OK, since the DSP support has been improved a lot in comparison with
the early stage, so it makes sense. I believe most of distros have
set already this to y, and it won't be any big impact.

Applied now. Thanks.


Takashi