2020-04-02 00:17:26

by Sarthak Kukreti

Subject: [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size

On x86 ChromiumOS devices, the pmsg_size is set to 0 (check
/sys/module/ramoops/parameters/pmsg_size): this prevents use of
pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size
to a value that is consistent with the size used on non-x86 ChromiumOS
devices.

Signed-off-by: Sarthak Kukreti <[email protected]>
---
drivers/platform/chrome/chromeos_pstore.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
index d13770785fb5..82dea8cb5da1 100644
--- a/drivers/platform/chrome/chromeos_pstore.c
+++ b/drivers/platform/chrome/chromeos_pstore.c
@@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = {
.record_size = 0x40000,
.console_size = 0x20000,
.ftrace_size = 0x20000,
+ .pmsg_size = 0x20000,
.dump_oops = 1,
};

--
2.26.0.rc2.310.g2932bb562d-goog

2020-04-02 07:12:18

by Kees Cook

Subject: Re: [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size

On Wed, Apr 01, 2020 at 05:15:48PM -0700, Sarthak Kukreti wrote:
> On x86 ChromiumOS devices, the pmsg_size is set to 0 (check
> /sys/module/ramoops/parameters/pmsg_size): this prevents use of
> pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size
> to a value that is consistent with the size used on non-x86 ChromiumOS
> devices.
>
> Signed-off-by: Sarthak Kukreti <[email protected]>

Reviewed-by: Kees Cook <[email protected]>

-Kees

> ---
> drivers/platform/chrome/chromeos_pstore.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index d13770785fb5..82dea8cb5da1 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = {
> .record_size = 0x40000,
> .console_size = 0x20000,
> .ftrace_size = 0x20000,
> + .pmsg_size = 0x20000,
> .dump_oops = 1,
> };
>
> --
> 2.26.0.rc2.310.g2932bb562d-goog
>

--
Kees Cook

2020-04-15 21:36:55

by Enric Balletbo i Serra

Subject: Re: [PATCH 1/1] platform/chrome: chromeos_pstore: set user space log size

Hi Sarthak,

Thank you for your patch.

On 2/4/20 2:15, Sarthak Kukreti wrote:
> On x86 ChromiumOS devices, the pmsg_size is set to 0 (check
> /sys/module/ramoops/parameters/pmsg_size): this prevents use of
> pstore-pmsg, even if CONFIG_PSTORE_PMSG is enabled. Set pmsg_size
> to a value that is consistent with the size used on non-x86 ChromiumOS
> devices.
>
> Signed-off-by: Sarthak Kukreti <[email protected]>
> ---

Applied for 5.8

> drivers/platform/chrome/chromeos_pstore.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/chrome/chromeos_pstore.c b/drivers/platform/chrome/chromeos_pstore.c
> index d13770785fb5..82dea8cb5da1 100644
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@ -57,6 +57,7 @@ static struct ramoops_platform_data chromeos_ramoops_data = {
> .record_size = 0x40000,
> .console_size = 0x20000,
> .ftrace_size = 0x20000,
> + .pmsg_size = 0x20000,
> .dump_oops = 1,
> };
>
>