2020-04-07 08:35:24

by [email protected]

Subject: [PATCH] exfat: remove 'bps' mount-option

remount fails because exfat_show_options() returns unsupported option 'bps'.
> # mount -o ro,remount
> exfat: Unknown parameter 'bps'

To fix the problem, just remove 'bps' option from exfat_show_options().

Signed-off-by: Tetsuhiro Kohada <[email protected]>
---
fs/exfat/super.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/exfat/super.c b/fs/exfat/super.c
index 2dd62543a4..1b7d2eb034 100644
--- a/fs/exfat/super.c
+++ b/fs/exfat/super.c
@@ -151,7 +151,6 @@ static int exfat_show_options(struct seq_file *m, struct dentry *root)
seq_puts(m, ",iocharset=utf8");
else if (sbi->nls_io)
seq_printf(m, ",iocharset=%s", sbi->nls_io->charset);
- seq_printf(m, ",bps=%ld", sb->s_blocksize);
if (opts->errors == EXFAT_ERRORS_CONT)
seq_puts(m, ",errors=continue");
else if (opts->errors == EXFAT_ERRORS_PANIC)
--
2.25.0

2020-04-08 00:05:43

by Namjae Jeon

Subject: RE: [PATCH] exfat: remove 'bps' mount-option

> remount fails because exfat_show_options() returns unsupported option
> 'bps'.
> > # mount -o ro,remount
> > exfat: Unknown parameter 'bps'
>
> To fix the problem, just remove 'bps' option from exfat_show_options().
>
> Signed-off-by: Tetsuhiro Kohada
> <[email protected]>
I will apply your patches after setting up exfat git tree.

Thanks for your work!
> ---
> fs/exfat/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> 2dd62543a4..1b7d2eb034 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -151,7 +151,6 @@ static int exfat_show_options(struct seq_file *m,
> struct dentry *root)
> seq_puts(m, ",iocharset=utf8");
> else if (sbi->nls_io)
> seq_printf(m, ",iocharset=%s", sbi->nls_io->charset);
> - seq_printf(m, ",bps=%ld", sb->s_blocksize);
> if (opts->errors == EXFAT_ERRORS_CONT)
> seq_puts(m, ",errors=continue");
> else if (opts->errors == EXFAT_ERRORS_PANIC)
> --
> 2.25.0