2020-03-31 10:47:25

by Chunyan Zhang

Subject: [PATCH] clk: sprd: don't gate uart console clock

Don't gate uart1_eb which provides console clock, gating that clock would
make serial stop working if serial driver didn't enable that explicitly.

Signed-off-by: Chunyan Zhang <[email protected]>
---
drivers/clk/sprd/sc9863a-clk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/sprd/sc9863a-clk.c b/drivers/clk/sprd/sc9863a-clk.c
index 24f064262814..6c6ac158ef61 100644
--- a/drivers/clk/sprd/sc9863a-clk.c
+++ b/drivers/clk/sprd/sc9863a-clk.c
@@ -1671,8 +1671,9 @@ static SPRD_SC_GATE_CLK_FW_NAME(i2c4_eb, "i2c4-eb", "ext-26m", 0x0,
0x1000, BIT(12), 0, 0);
static SPRD_SC_GATE_CLK_FW_NAME(uart0_eb, "uart0-eb", "ext-26m", 0x0,
0x1000, BIT(13), 0, 0);
+/* uart1_eb is for console, don't gate even if unused */
static SPRD_SC_GATE_CLK_FW_NAME(uart1_eb, "uart1-eb", "ext-26m", 0x0,
- 0x1000, BIT(14), 0, 0);
+ 0x1000, BIT(14), CLK_IGNORE_UNUSED, 0);
static SPRD_SC_GATE_CLK_FW_NAME(uart2_eb, "uart2-eb", "ext-26m", 0x0,
0x1000, BIT(15), 0, 0);
static SPRD_SC_GATE_CLK_FW_NAME(uart3_eb, "uart3-eb", "ext-26m", 0x0,
--
2.20.1

2020-04-03 01:58:14

by Chunyan Zhang

Subject: Re: [PATCH] clk: sprd: don't gate uart console clock

Hi Stephen,

This is also a fix, could you please take it into clk-next as well?

Thanks,
Chunyan

On Tue, 31 Mar 2020 at 18:45, Chunyan Zhang <[email protected]> wrote:
>
> Don't gate uart1_eb which provides console clock, gating that clock would
> make serial stop working if serial driver didn't enable that explicitly.
>
> Signed-off-by: Chunyan Zhang <[email protected]>
> ---
> drivers/clk/sprd/sc9863a-clk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sprd/sc9863a-clk.c b/drivers/clk/sprd/sc9863a-clk.c
> index 24f064262814..6c6ac158ef61 100644
> --- a/drivers/clk/sprd/sc9863a-clk.c
> +++ b/drivers/clk/sprd/sc9863a-clk.c
> @@ -1671,8 +1671,9 @@ static SPRD_SC_GATE_CLK_FW_NAME(i2c4_eb, "i2c4-eb", "ext-26m", 0x0,
> 0x1000, BIT(12), 0, 0);
> static SPRD_SC_GATE_CLK_FW_NAME(uart0_eb, "uart0-eb", "ext-26m", 0x0,
> 0x1000, BIT(13), 0, 0);
> +/* uart1_eb is for console, don't gate even if unused */
> static SPRD_SC_GATE_CLK_FW_NAME(uart1_eb, "uart1-eb", "ext-26m", 0x0,
> - 0x1000, BIT(14), 0, 0);
> + 0x1000, BIT(14), CLK_IGNORE_UNUSED, 0);
> static SPRD_SC_GATE_CLK_FW_NAME(uart2_eb, "uart2-eb", "ext-26m", 0x0,
> 0x1000, BIT(15), 0, 0);
> static SPRD_SC_GATE_CLK_FW_NAME(uart3_eb, "uart3-eb", "ext-26m", 0x0,
> --
> 2.20.1
>

2020-04-05 03:09:15

by Stephen Boyd

Subject: Re: [PATCH] clk: sprd: don't gate uart console clock

Quoting Chunyan Zhang (2020-03-31 03:45:32)
> Don't gate uart1_eb which provides console clock, gating that clock would
> make serial stop working if serial driver didn't enable that explicitly.
>
> Signed-off-by: Chunyan Zhang <[email protected]>
> ---

Do you have a Fixes: tag?

2020-04-07 02:04:34

by Chunyan Zhang

Subject: Re: [PATCH] clk: sprd: don't gate uart console clock

On Sun, 5 Apr 2020 at 11:08, Stephen Boyd <[email protected]> wrote:
>
> Quoting Chunyan Zhang (2020-03-31 03:45:32)
> > Don't gate uart1_eb which provides console clock, gating that clock would
> > make serial stop working if serial driver didn't enable that explicitly.
> >
> > Signed-off-by: Chunyan Zhang <[email protected]>
> > ---
>
> Do you have a Fixes: tag?

I didn't leave a Fixed tag since that commit [1] will be merged into v5.7-rc1

[1] https://www.spinics.net/lists/linux-clk/msg46430.html

2020-04-07 20:35:45

by Stephen Boyd

Subject: Re: [PATCH] clk: sprd: don't gate uart console clock

Quoting Chunyan Zhang (2020-04-06 19:02:38)
> On Sun, 5 Apr 2020 at 11:08, Stephen Boyd <[email protected]> wrote:
> >
> > Quoting Chunyan Zhang (2020-03-31 03:45:32)
> > > Don't gate uart1_eb which provides console clock, gating that clock would
> > > make serial stop working if serial driver didn't enable that explicitly.
> > >
> > > Signed-off-by: Chunyan Zhang <[email protected]>
> > > ---
> >
> > Do you have a Fixes: tag?
>
> I didn't leave a Fixed tag since that commit [1] will be merged into v5.7-rc1
>
> [1] https://www.spinics.net/lists/linux-clk/msg46430.html

Please still provide a Fixes tag. It helps track what commit is fixed
regardless.

2020-04-08 02:03:25

by Chunyan Zhang

Subject: [PATCH] clk: sprd: don't gate uart console clock

From: Chunyan Zhang <[email protected]>

Don't gate uart1_eb which provides console clock, gating that clock would
make serial stop working if serial driver didn't enable that explicitly.

Fixes: 0e4b8a2349f3 ("clk: sprd: add clocks support for SC9863A")
Signed-off-by: Chunyan Zhang <[email protected]>
---
drivers/clk/sprd/sc9863a-clk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/sprd/sc9863a-clk.c b/drivers/clk/sprd/sc9863a-clk.c
index 24f064262814..6c6ac158ef61 100644
--- a/drivers/clk/sprd/sc9863a-clk.c
+++ b/drivers/clk/sprd/sc9863a-clk.c
@@ -1671,8 +1671,9 @@ static SPRD_SC_GATE_CLK_FW_NAME(i2c4_eb, "i2c4-eb", "ext-26m", 0x0,
0x1000, BIT(12), 0, 0);
static SPRD_SC_GATE_CLK_FW_NAME(uart0_eb, "uart0-eb", "ext-26m", 0x0,
0x1000, BIT(13), 0, 0);
+/* uart1_eb is for console, don't gate even if unused */
static SPRD_SC_GATE_CLK_FW_NAME(uart1_eb, "uart1-eb", "ext-26m", 0x0,
- 0x1000, BIT(14), 0, 0);
+ 0x1000, BIT(14), CLK_IGNORE_UNUSED, 0);
static SPRD_SC_GATE_CLK_FW_NAME(uart2_eb, "uart2-eb", "ext-26m", 0x0,
0x1000, BIT(15), 0, 0);
static SPRD_SC_GATE_CLK_FW_NAME(uart3_eb, "uart3-eb", "ext-26m", 0x0,
--
2.20.1

2020-04-11 02:21:57

by Stephen Boyd

Subject: Re: [PATCH] clk: sprd: don't gate uart console clock

Quoting Chunyan Zhang (2020-04-07 19:02:34)
> From: Chunyan Zhang <[email protected]>
>
> Don't gate uart1_eb which provides console clock, gating that clock would
> make serial stop working if serial driver didn't enable that explicitly.
>
> Fixes: 0e4b8a2349f3 ("clk: sprd: add clocks support for SC9863A")
> Signed-off-by: Chunyan Zhang <[email protected]>
> ---

Applied to clk-fixes