2020-04-08 20:17:32

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v3 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's

On Wed, Apr 08, 2020 at 02:14:02PM -0400, Al Cooper wrote:
> v3 - Addressed all of Andy Shevchenko's review comments for
> ehci-brcm.c.
> - Fixed the brcm,bcm7445-ehci.yaml dt-bindings document,
> dt_binding_check now passes.
> - Added the XHCI functionality to xhci-plat.c instead of creating
> new brcmstb files, as suggested by Mathias Nyman.

It's nice, but have you heard what Mathias asked / proposed?

> v2 - Addressed Andy Shevchenko's review comments.
> - Fixed dt_binding_check error pointed out by Rob Herring.
> - Removed pr_info message in ehci_brcm_init as suggested by
> Greg Kroah-Hartman.
>
> This adds support for the XHCI, EHCI and OHCI host controllers found
> in Broadcom STB SoC's. These drivers depend on getting access to the
> new Broadcom STB USB PHY driver through a device-tree phandle and
> will fail if the driver is not available.
>
> Al Cooper (4):
> dt-bindings: Add Broadcom STB USB support
> usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
> usb: ehci: Add new EHCI driver for Broadcom STB SoC's
> usb: host: Add ability to build new Broadcom STB USB drivers
>
> .../bindings/usb/brcm,bcm7445-ehci.yaml | 60 ++++
> .../devicetree/bindings/usb/usb-xhci.txt | 1 +
> MAINTAINERS | 8 +
> drivers/usb/host/Kconfig | 16 +
> drivers/usb/host/Makefile | 16 +-
> drivers/usb/host/ehci-brcm.c | 286 ++++++++++++++++++
> drivers/usb/host/xhci-plat.c | 10 +
> 7 files changed, 391 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> create mode 100644 drivers/usb/host/ehci-brcm.c
>
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko



2020-04-08 20:30:29

by Al Cooper

[permalink] [raw]
Subject: Re: [PATCH v3 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's

On Wed, Apr 8, 2020 at 2:25 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Wed, Apr 08, 2020 at 02:14:02PM -0400, Al Cooper wrote:
> > v3 - Addressed all of Andy Shevchenko's review comments for
> > ehci-brcm.c.
> > - Fixed the brcm,bcm7445-ehci.yaml dt-bindings document,
> > dt_binding_check now passes.
> > - Added the XHCI functionality to xhci-plat.c instead of creating
> > new brcmstb files, as suggested by Mathias Nyman.
>
> It's nice, but have you heard what Mathias asked / proposed?

I thought that was what I did.

Al

...


>
> > v2 - Addressed Andy Shevchenko's review comments.
> > - Fixed dt_binding_check error pointed out by Rob Herring.
> > - Removed pr_info message in ehci_brcm_init as suggested by
> > Greg Kroah-Hartman.
> >
> > This adds support for the XHCI, EHCI and OHCI host controllers found
> > in Broadcom STB SoC's. These drivers depend on getting access to the
> > new Broadcom STB USB PHY driver through a device-tree phandle and
> > will fail if the driver is not available.
> >
> > Al Cooper (4):
> > dt-bindings: Add Broadcom STB USB support
> > usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
> > usb: ehci: Add new EHCI driver for Broadcom STB SoC's
> > usb: host: Add ability to build new Broadcom STB USB drivers
> >
> > .../bindings/usb/brcm,bcm7445-ehci.yaml | 60 ++++
> > .../devicetree/bindings/usb/usb-xhci.txt | 1 +
> > MAINTAINERS | 8 +
> > drivers/usb/host/Kconfig | 16 +
> > drivers/usb/host/Makefile | 16 +-
> > drivers/usb/host/ehci-brcm.c | 286 ++++++++++++++++++
> > drivers/usb/host/xhci-plat.c | 10 +
> > 7 files changed, 391 insertions(+), 6 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml
> > create mode 100644 drivers/usb/host/ehci-brcm.c
> >
> > --
> > 2.17.1
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>