2020-04-15 13:27:18

by Jerry Snitselaar

[permalink] [raw]
Subject: Re: [PATCH] tpm: fix wrong return value in tpm_pcr_extend

On Tue Apr 14 20, Jarkko Sakkinen wrote:
>On Tue, Apr 14, 2020 at 11:55:43AM +0000, Roberto Sassu wrote:
>> > -----Original Message-----
>> > From: [email protected] [mailto:linux-integrity-
>> > [email protected]] On Behalf Of Tianjia Zhang
>> > Sent: Tuesday, April 14, 2020 1:42 PM
>> > To: [email protected]; [email protected]; [email protected];
>> > [email protected]; [email protected]; [email protected]
>> > Cc: [email protected]; [email protected];
>> > [email protected]
>> > Subject: [PATCH] tpm: fix wrong return value in tpm_pcr_extend
>> >
>> > For the algorithm that does not match the bank, a positive
>> > value EINVAL is returned here. I think this is a typo error.
>> > It is necessary to return an error value.
>>
>> Yes, thanks.
>>
>> Reviewed-by: Roberto Sassu <[email protected]>
>
>Happen to have the commit ID at hand for fixes?
>
>Thanks.
>
>/Jarkko
>

9f75c8224631 ("KEYS: trusted: correctly initialize digests and fix locking issue")


2020-04-16 16:13:47

by Jarkko Sakkinen

[permalink] [raw]
Subject: Re: [PATCH] tpm: fix wrong return value in tpm_pcr_extend

On Tue, Apr 14, 2020 at 01:26:15PM -0700, Jerry Snitselaar wrote:
> On Tue Apr 14 20, Jarkko Sakkinen wrote:
> > On Tue, Apr 14, 2020 at 11:55:43AM +0000, Roberto Sassu wrote:
> > > > -----Original Message-----
> > > > From: [email protected] [mailto:linux-integrity-
> > > > [email protected]] On Behalf Of Tianjia Zhang
> > > > Sent: Tuesday, April 14, 2020 1:42 PM
> > > > To: [email protected]; [email protected]; [email protected];
> > > > [email protected]; [email protected]; [email protected]
> > > > Cc: [email protected]; [email protected];
> > > > [email protected]
> > > > Subject: [PATCH] tpm: fix wrong return value in tpm_pcr_extend
> > > >
> > > > For the algorithm that does not match the bank, a positive
> > > > value EINVAL is returned here. I think this is a typo error.
> > > > It is necessary to return an error value.
> > >
> > > Yes, thanks.
> > >
> > > Reviewed-by: Roberto Sassu <[email protected]>
> >
> > Happen to have the commit ID at hand for fixes?
> >
> > Thanks.
> >
> > /Jarkko
> >
>
> 9f75c8224631 ("KEYS: trusted: correctly initialize digests and fix locking issue")

Thanks.

Also added:

Cc: [email protected] # 5.4.x

/Jarkko