2020-04-15 22:31:39

by Jason Yan

Subject: [PATCH] firmware: xilinx: make firmware_debugfs_root static

Fix the following sparse warning:

drivers/firmware/xilinx/zynqmp-debug.c:38:15: warning: symbol
'firmware_debugfs_root' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Jason Yan <[email protected]>
---
drivers/firmware/xilinx/zynqmp-debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/xilinx/zynqmp-debug.c b/drivers/firmware/xilinx/zynqmp-debug.c
index c6d0724da4db..43bc6cfdab45 100644
--- a/drivers/firmware/xilinx/zynqmp-debug.c
+++ b/drivers/firmware/xilinx/zynqmp-debug.c
@@ -35,7 +35,7 @@ static struct pm_api_info pm_api_list[] = {
PM_API(PM_QUERY_DATA),
};

-struct dentry *firmware_debugfs_root;
+static struct dentry *firmware_debugfs_root;

/**
* zynqmp_pm_argument_value() - Extract argument value from a PM-API request
--
2.21.1

2020-04-15 22:32:22

by Michal Simek

Subject: Re: [PATCH] firmware: xilinx: make firmware_debugfs_root static

On 15. 04. 20 10:43, Jason Yan wrote:
> Fix the following sparse warning:
>
> drivers/firmware/xilinx/zynqmp-debug.c:38:15: warning: symbol
> 'firmware_debugfs_root' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Jason Yan <[email protected]>
> ---
> drivers/firmware/xilinx/zynqmp-debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/xilinx/zynqmp-debug.c b/drivers/firmware/xilinx/zynqmp-debug.c
> index c6d0724da4db..43bc6cfdab45 100644
> --- a/drivers/firmware/xilinx/zynqmp-debug.c
> +++ b/drivers/firmware/xilinx/zynqmp-debug.c
> @@ -35,7 +35,7 @@ static struct pm_api_info pm_api_list[] = {
> PM_API(PM_QUERY_DATA),
> };
>
> -struct dentry *firmware_debugfs_root;
> +static struct dentry *firmware_debugfs_root;
>
> /**
> * zynqmp_pm_argument_value() - Extract argument value from a PM-API request
>

Applied.

Thanks,
Michal