Convert the i.MX6Q clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <[email protected]>
---
.../devicetree/bindings/clock/imx6q-clock.txt | 41 -------------
.../devicetree/bindings/clock/imx6q-clock.yaml | 69 ++++++++++++++++++++++
2 files changed, 69 insertions(+), 41 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.txt
create mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.yaml
diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.txt b/Documentation/devicetree/bindings/clock/imx6q-clock.txt
deleted file mode 100644
index 13d36d4..0000000
--- a/Documentation/devicetree/bindings/clock/imx6q-clock.txt
+++ /dev/null
@@ -1,41 +0,0 @@
-* Clock bindings for Freescale i.MX6 Quad
-
-Required properties:
-- compatible: Should be "fsl,imx6q-ccm"
-- reg: Address and length of the register set
-- interrupts: Should contain CCM interrupt
-- #clock-cells: Should be <1>
-
-Optional properties:
-- fsl,pmic-stby-poweroff: Configure CCM to assert PMIC_STBY_REQ signal
- on power off.
- Use this property if the SoC should be powered off by external power
- management IC (PMIC) triggered via PMIC_STBY_REQ signal.
- Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should
- be using "syscon-poweroff" driver instead.
-- clocks: list of clock specifiers, must contain an entry for each entry
- in clock-names
-- clock-names: valid names are "osc", "ckil", "ckih1", "anaclk1" and "anaclk2"
-
-The clock consumer should specify the desired clock by having the clock
-ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx6qdl-clock.h
-for the full list of i.MX6 Quad and DualLite clock IDs.
-
-Examples:
-
-#include <dt-bindings/clock/imx6qdl-clock.h>
-
-clks: ccm@20c4000 {
- compatible = "fsl,imx6q-ccm";
- reg = <0x020c4000 0x4000>;
- interrupts = <0 87 0x04 0 88 0x04>;
- #clock-cells = <1>;
-};
-
-uart1: serial@2020000 {
- compatible = "fsl,imx6q-uart", "fsl,imx21-uart";
- reg = <0x02020000 0x4000>;
- interrupts = <0 26 0x04>;
- clocks = <&clks IMX6QDL_CLK_UART_IPG>, <&clks IMX6QDL_CLK_UART_SERIAL>;
- clock-names = "ipg", "per";
-};
diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
new file mode 100644
index 0000000..084d4f0
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/imx6q-clock.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Clock bindings for Freescale i.MX6 Quad
+
+maintainers:
+ - Anson Huang <[email protected]>
+
+properties:
+ compatible:
+ const: fsl,imx6q-ccm
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ minItems: 1
+ maxItems: 2
+
+ '#clock-cells':
+ const: 1
+
+ clocks:
+ items:
+ - description: 24m osc
+ - description: 32k osc
+ - description: ckih1 clock input
+ - description: anaclk1 clock input
+ - description: anaclk2 clock input
+
+ clock-names:
+ items:
+ - const: osc
+ - const: ckil
+ - const: ckih1
+ - const: anaclk1
+ - const: anaclk2
+
+ fsl,pmic-stby-poweroff:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description: |
+ Use this property if the SoC should be powered off by external power
+ management IC (PMIC) triggered via PMIC_STBY_REQ signal.
+ Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should
+ be using "syscon-poweroff" driver instead.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - '#clock-cells'
+
+examples:
+ # Clock Control Module node:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ clks: clock-controller@20c4000 {
+ compatible = "fsl,imx6q-ccm";
+ reg = <0x020c4000 0x4000>;
+ interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>,
+ <0 88 IRQ_TYPE_LEVEL_HIGH>;
+ #clock-cells = <1>;
+ };
+
+...
--
2.7.4
Convert the i.MX6SL clock binding to DT schema format using json-schema.
Signed-off-by: Anson Huang <[email protected]>
---
.../devicetree/bindings/clock/imx6sl-clock.txt | 10 -----
.../devicetree/bindings/clock/imx6sl-clock.yaml | 45 ++++++++++++++++++++++
2 files changed, 45 insertions(+), 10 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/imx6sl-clock.txt
create mode 100644 Documentation/devicetree/bindings/clock/imx6sl-clock.yaml
diff --git a/Documentation/devicetree/bindings/clock/imx6sl-clock.txt b/Documentation/devicetree/bindings/clock/imx6sl-clock.txt
deleted file mode 100644
index 15e40bd..0000000
--- a/Documentation/devicetree/bindings/clock/imx6sl-clock.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-* Clock bindings for Freescale i.MX6 SoloLite
-
-Required properties:
-- compatible: Should be "fsl,imx6sl-ccm"
-- reg: Address and length of the register set
-- #clock-cells: Should be <1>
-
-The clock consumer should specify the desired clock by having the clock
-ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx6sl-clock.h
-for the full list of i.MX6 SoloLite clock IDs.
diff --git a/Documentation/devicetree/bindings/clock/imx6sl-clock.yaml b/Documentation/devicetree/bindings/clock/imx6sl-clock.yaml
new file mode 100644
index 0000000..6e571bc
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/imx6sl-clock.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/imx6sl-clock.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Clock bindings for Freescale i.MX6 SoloLite
+
+maintainers:
+ - Anson Huang <[email protected]>
+
+properties:
+ compatible:
+ const: fsl,imx6sl-ccm
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ minItems: 1
+ maxItems: 2
+
+ '#clock-cells':
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - '#clock-cells'
+
+examples:
+ # Clock Control Module node:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ clks: clock-controller@20c4000 {
+ compatible = "fsl,imx6sl-ccm";
+ reg = <0x020c4000 0x4000>;
+ interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>,
+ <0 88 IRQ_TYPE_LEVEL_HIGH>;
+ #clock-cells = <1>;
+ };
+
+...
--
2.7.4
Hi Anson,
thanks for the patch. I have two questions please see inline which
applies to all patches.
On 20-04-16 12:26, Anson Huang wrote:
...
> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> new file mode 100644
> index 0000000..084d4f0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/imx6q-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Clock bindings for Freescale i.MX6 Quad
> +
> +maintainers:
> + - Anson Huang <[email protected]>
> +
> +properties:
> + compatible:
> + const: fsl,imx6q-ccm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 1
Why 1 and not 2? The RM describes that the ccm has 2 interrupts.
> + maxItems: 2
> +
> + '#clock-cells':
> + const: 1
> +
> + clocks:
> + items:
> + - description: 24m osc
> + - description: 32k osc
> + - description: ckih1 clock input
> + - description: anaclk1 clock input
> + - description: anaclk2 clock input
> +
> + clock-names:
> + items:
> + - const: osc
> + - const: ckil
> + - const: ckih1
> + - const: anaclk1
> + - const: anaclk2
> +
> + fsl,pmic-stby-poweroff:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: |
> + Use this property if the SoC should be powered off by external power
> + management IC (PMIC) triggered via PMIC_STBY_REQ signal.
> + Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should
> + be using "syscon-poweroff" driver instead.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - '#clock-cells'
> +
> +examples:
> + # Clock Control Module node:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + clks: clock-controller@20c4000 {
> + compatible = "fsl,imx6q-ccm";
> + reg = <0x020c4000 0x4000>;
> + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>,
> + <0 88 IRQ_TYPE_LEVEL_HIGH>;
> + #clock-cells = <1>;
> + };
> +
> +...
Why these '...' here?
Regards,
Marco
> --
> 2.7.4
Hi, Marco
> Subject: Re: [PATCH 1/5] dt-bindings: clock: Convert i.MX6Q clock to
> json-schema
>
> Hi Anson,
>
> thanks for the patch. I have two questions please see inline which applies to all
> patches.
>
> On 20-04-16 12:26, Anson Huang wrote:
>
> ...
>
> > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > new file mode 100644
> > index 0000000..084d4f0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fclock%2Fimx6q-clock.yaml%23&data=02%7C
> 01%7
> >
> +Canson.huang%40nxp.com%7Cf07db2c34e834628725208d7e1c63083%7C6
> 86ea1d3b
> >
> +c2b4c6fa92cd99c5c301635%7C0%7C0%7C637226113645218967&sdat
> a=sBVaIF
> > +hEoFSfaot7P%2Bjcbu6gnAlaB%2BDeEUqn3sv3%2BA8%3D&reserved=0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cans
> on.hua
> >
> +ng%40nxp.com%7Cf07db2c34e834628725208d7e1c63083%7C686ea1d3bc2
> b4c6fa92
> >
> +cd99c5c301635%7C0%7C0%7C637226113645218967&sdata=KLIuh1sJ
> 2OQDp%2B
> > +zSncLn87ziXGb85rwJFu2NnLgvxGI%3D&reserved=0
> > +
> > +title: Clock bindings for Freescale i.MX6 Quad
> > +
> > +maintainers:
> > + - Anson Huang <[email protected]>
> > +
> > +properties:
> > + compatible:
> > + const: fsl,imx6q-ccm
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + minItems: 1
>
> Why 1 and not 2? The RM describes that the ccm has 2 interrupts.
This is a typo, since we all use 2 interrupts for ccm, I will change them to ONLY 2;
>
> > + maxItems: 2
> > +
> > + '#clock-cells':
> > + const: 1
> > +
> > + clocks:
> > + items:
> > + - description: 24m osc
> > + - description: 32k osc
> > + - description: ckih1 clock input
> > + - description: anaclk1 clock input
> > + - description: anaclk2 clock input
> > +
> > + clock-names:
> > + items:
> > + - const: osc
> > + - const: ckil
> > + - const: ckih1
> > + - const: anaclk1
> > + - const: anaclk2
> > +
> > + fsl,pmic-stby-poweroff:
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + description: |
> > + Use this property if the SoC should be powered off by external power
> > + management IC (PMIC) triggered via PMIC_STBY_REQ signal.
> > + Boards that are designed to initiate poweroff on PMIC_ON_REQ
> signal should
> > + be using "syscon-poweroff" driver instead.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - '#clock-cells'
> > +
> > +examples:
> > + # Clock Control Module node:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + clks: clock-controller@20c4000 {
> > + compatible = "fsl,imx6q-ccm";
> > + reg = <0x020c4000 0x4000>;
> > + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>,
> > + <0 88 IRQ_TYPE_LEVEL_HIGH>;
> > + #clock-cells = <1>;
> > + };
> > +
> > +...
>
> Why these '...' here?
I will remove it
Thanks,
Anson
>
> Regards,
> Marco
>
> > --
> > 2.7.4