2020-04-17 12:46:04

by Maxime Ripard

[permalink] [raw]
Subject: Re: [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

Hi,

Cc'ing Laurent

On Fri, Apr 17, 2020 at 02:18:11PM +0200, H. Nikolaus Schaller wrote:
> Hi Maxime,
> I have started to test v5.7-rc1 and can't fully boot the GTA04
> device any more.
>
> What I see in the log is:
>
> [ 28.567840] [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!
> [ 28.567871] omapdrm omapdrm.0: unable to attach bridge /ocp@68000000/dss@48050000/encoder@48050c00
> [ 28.786529] omapdrm omapdrm.0: omap_modeset_init failed: ret=-22
> [ 28.841552] omapdrm: probe of omapdrm.0 failed with error -22
>
> This device uses the ti,opa362 chip which did have a dedicated
> omapdss driver before (which is removed now) and which seems to
> be supported by the simple_bridge now.
>
> The opa362 is sitting in the video out path from
>
> omapdrm -> venc -> opa362 -> video-out-connector.
>
> What does this error mean? How can it be fixed?

-22 is usually EINVAL, which can be pretty much anything. A good thing to do
would be to bisect to see which actual commit broke it, but if I was to bet on
something I guess it would be

https://lore.kernel.org/dri-devel/[email protected]/

Maxime


Attachments:
(No filename) (1.21 kB)
signature.asc (235.00 B)
Download all attachments

2020-04-17 13:03:00

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

Hello,

On Fri, Apr 17, 2020 at 02:44:22PM +0200, Maxime Ripard wrote:
> On Fri, Apr 17, 2020 at 02:18:11PM +0200, H. Nikolaus Schaller wrote:
> > Hi Maxime,
> > I have started to test v5.7-rc1 and can't fully boot the GTA04
> > device any more.
> >
> > What I see in the log is:
> >
> > [ 28.567840] [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!
> > [ 28.567871] omapdrm omapdrm.0: unable to attach bridge /ocp@68000000/dss@48050000/encoder@48050c00
> > [ 28.786529] omapdrm omapdrm.0: omap_modeset_init failed: ret=-22
> > [ 28.841552] omapdrm: probe of omapdrm.0 failed with error -22
> >
> > This device uses the ti,opa362 chip which did have a dedicated
> > omapdss driver before (which is removed now) and which seems to
> > be supported by the simple_bridge now.
> >
> > The opa362 is sitting in the video out path from
> >
> > omapdrm -> venc -> opa362 -> video-out-connector.
> >
> > What does this error mean? How can it be fixed?
>
> -22 is usually EINVAL, which can be pretty much anything. A good thing to do
> would be to bisect to see which actual commit broke it, but if I was to bet on
> something I guess it would be
>
> https://lore.kernel.org/dri-devel/[email protected]/

Would "[PATCH 0/2] drm: bridge: simple-bridge: Enable usage with DRM
bridge connector helper" solve it ?

--
Regards,

Laurent Pinchart

2020-04-17 13:55:23

by H. Nikolaus Schaller

[permalink] [raw]
Subject: Re: [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

Hi Laurent,

> Am 17.04.2020 um 14:58 schrieb Laurent Pinchart <[email protected]>:
>
> Hello,
>
> On Fri, Apr 17, 2020 at 02:44:22PM +0200, Maxime Ripard wrote:
>> On Fri, Apr 17, 2020 at 02:18:11PM +0200, H. Nikolaus Schaller wrote:
>>> Hi Maxime,
>>> I have started to test v5.7-rc1 and can't fully boot the GTA04
>>> device any more.
>>>
>>> What I see in the log is:
>>>
>>> [ 28.567840] [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!
>>> [ 28.567871] omapdrm omapdrm.0: unable to attach bridge /ocp@68000000/dss@48050000/encoder@48050c00
>>> [ 28.786529] omapdrm omapdrm.0: omap_modeset_init failed: ret=-22
>>> [ 28.841552] omapdrm: probe of omapdrm.0 failed with error -22
>>>
>>> This device uses the ti,opa362 chip which did have a dedicated
>>> omapdss driver before (which is removed now) and which seems to
>>> be supported by the simple_bridge now.
>>>
>>> The opa362 is sitting in the video out path from
>>>
>>> omapdrm -> venc -> opa362 -> video-out-connector.
>>>
>>> What does this error mean? How can it be fixed?
>>
>> -22 is usually EINVAL, which can be pretty much anything. A good thing to do
>> would be to bisect to see which actual commit broke it, but if I was to bet on
>> something I guess it would be
>>
>> https://lore.kernel.org/dri-devel/[email protected]/
>
> Would "[PATCH 0/2] drm: bridge: simple-bridge: Enable usage with DRM
> bridge connector helper" solve it ?

Yes, seems to magically solve the boot issue!

I'll confirm later if the opa362 is still (or again) working.

BR and thanks,
Nikolaus Schaller