2020-04-17 16:28:39

by chengkaitao

[permalink] [raw]
Subject: [PATCH RESEND] kernel/smp: Use smp_call_func_t in on_each_cpu()

There is already a typedef smp_call_func_t, so we can just use it,
maybe better.

Fixes: 3a5f65df5a0fc ("Typedef SMP call function pointer")
Signed-off-by: Kaitao Cheng <[email protected]>
---
kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/smp.c b/kernel/smp.c
index 786092aabdcd..84303197caf9 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -620,7 +620,7 @@ void __init smp_init(void)
* early_boot_irqs_disabled is set. Use local_irq_save/restore() instead
* of local_irq_disable/enable().
*/
-void on_each_cpu(void (*func) (void *info), void *info, int wait)
+void on_each_cpu(smp_call_func_t func, void *info, int wait)
{
unsigned long flags;

--
2.20.1


Subject: Re: [PATCH RESEND] kernel/smp: Use smp_call_func_t in on_each_cpu()

On 2020-04-18 00:24:51 [+0800], Kaitao Cheng wrote:
> There is already a typedef smp_call_func_t, so we can just use it,
> maybe better.
>
> Fixes: 3a5f65df5a0fc ("Typedef SMP call function pointer")
> Signed-off-by: Kaitao Cheng <[email protected]>

I would not go as far as the Fixes: tag but otherwise:

Acked-by: Sebastian Andrzej Siewior <[email protected]>

> ---
> kernel/smp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index 786092aabdcd..84303197caf9 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -620,7 +620,7 @@ void __init smp_init(void)
> * early_boot_irqs_disabled is set. Use local_irq_save/restore() instead
> * of local_irq_disable/enable().
> */
> -void on_each_cpu(void (*func) (void *info), void *info, int wait)
> +void on_each_cpu(smp_call_func_t func, void *info, int wait)
> {
> unsigned long flags;
>

Sebastian

2020-04-19 03:26:16

by chengkaitao

[permalink] [raw]
Subject: Re: [PATCH RESEND] kernel/smp: Use smp_call_func_t in on_each_cpu()

On Sat, Apr 18, 2020 at 1:05 AM Sebastian Andrzej Siewior
<[email protected]> wrote:
>
> On 2020-04-18 00:24:51 [+0800], Kaitao Cheng wrote:
> > There is already a typedef smp_call_func_t, so we can just use it,
> > maybe better.
> >
> > Fixes: 3a5f65df5a0fc ("Typedef SMP call function pointer")
> > Signed-off-by: Kaitao Cheng <[email protected]>
>
> I would not go as far as the Fixes: tag but otherwise:
>
> Acked-by: Sebastian Andrzej Siewior <[email protected]>

Thanks for your review. Do you mean I should delete the Fixes tag?

>
> > ---
> > kernel/smp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/smp.c b/kernel/smp.c
> > index 786092aabdcd..84303197caf9 100644
> > --- a/kernel/smp.c
> > +++ b/kernel/smp.c
> > @@ -620,7 +620,7 @@ void __init smp_init(void)
> > * early_boot_irqs_disabled is set. Use local_irq_save/restore() instead
> > * of local_irq_disable/enable().
> > */
> > -void on_each_cpu(void (*func) (void *info), void *info, int wait)
> > +void on_each_cpu(smp_call_func_t func, void *info, int wait)
> > {
> > unsigned long flags;
> >
>
> Sebastian

Subject: [tip: smp/core] smp: Use smp_call_func_t in on_each_cpu()

The following commit has been merged into the smp/core branch of tip:

Commit-ID: 58eb7b77ad01f058e523554cb7bae7272a7d2579
Gitweb: https://git.kernel.org/tip/58eb7b77ad01f058e523554cb7bae7272a7d2579
Author: Kaitao Cheng <[email protected]>
AuthorDate: Sat, 18 Apr 2020 00:24:51 +08:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Sun, 19 Apr 2020 17:51:48 +02:00

smp: Use smp_call_func_t in on_each_cpu()

Use smp_call_func_t instead of the open coded function pointer argument.

Signed-off-by: Kaitao Cheng <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Sebastian Andrzej Siewior <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]

---
kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/smp.c b/kernel/smp.c
index 786092a..8430319 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -620,7 +620,7 @@ void __init smp_init(void)
* early_boot_irqs_disabled is set. Use local_irq_save/restore() instead
* of local_irq_disable/enable().
*/
-void on_each_cpu(void (*func) (void *info), void *info, int wait)
+void on_each_cpu(smp_call_func_t func, void *info, int wait)
{
unsigned long flags;