2020-04-20 21:54:15

by Colin King

Subject: [PATCH] net: ipv4: remove redundant assignment to variable rc

From: Colin Ian King <[email protected]>

The variable rc is being assigned with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
net/ipv4/af_inet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index cf58e29cf746..c618e242490f 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -1914,7 +1914,7 @@ static int __init inet_init(void)
{
struct inet_protosw *q;
struct list_head *r;
- int rc = -EINVAL;
+ int rc;

sock_skb_cb_check_size(sizeof(struct inet_skb_parm));

--
2.25.1

2020-04-20 23:29:52

by David Miller

Subject: Re: [PATCH] net: ipv4: remove redundant assignment to variable rc

From: Colin King <[email protected]>
Date: Mon, 20 Apr 2020 22:51:49 +0100

> From: Colin Ian King <[email protected]>
>
> The variable rc is being assigned with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Applied to net-next, thanks.