2020-04-22 00:46:39

by Prashant Malani

[permalink] [raw]

Subject: [PATCH] platform/chrome: typec: Fix ret value check error

---

cros_typec_add_partner() returns 0 on success, so check for "ret"
instead of "!ret" as an error.

Signed-off-by: Prashant Malani <[email protected]>
Fixes: 9d33ea331032 ("platform/chrome: cros_ec_typec: Register port partner")
---
drivers/platform/chrome/cros_ec_typec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index eda57db26f8d..66b8d21092af 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -263,7 +263,7 @@ static void cros_typec_set_port_params_v1(struct cros_typec_data *typec,

pd_en = resp->enabled & PD_CTRL_RESP_ENABLED_PD_CAPABLE;
ret = cros_typec_add_partner(typec, port_num, pd_en);
- if (!ret)
+ if (ret)
dev_warn(typec->dev,
"Failed to register partner on port: %d\n",
port_num);
--
2.26.1.301.g55bc3eb7cb9-goog

2020-04-22 00:58:43

by Benson Leung

[permalink] [raw]

Subject: Re: [PATCH] platform/chrome: typec: Fix ret value check error

---

Hi Prashant,

On Tue, Apr 21, 2020 at 05:41:51PM -0700, Prashant Malani wrote:
> cros_typec_add_partner() returns 0 on success, so check for "ret"
> instead of "!ret" as an error.
>
> Signed-off-by: Prashant Malani <[email protected]>
> Fixes: 9d33ea331032 ("platform/chrome: cros_ec_typec: Register port partner")

Thanks. Applied for 5.8.

origin/for-kernelci updated.

Thanks,
Benson

> ---
> drivers/platform/chrome/cros_ec_typec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index eda57db26f8d..66b8d21092af 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -263,7 +263,7 @@ static void cros_typec_set_port_params_v1(struct cros_typec_data *typec,
>
> pd_en = resp->enabled & PD_CTRL_RESP_ENABLED_PD_CAPABLE;
> ret = cros_typec_add_partner(typec, port_num, pd_en);
> - if (!ret)
> + if (ret)
> dev_warn(typec->dev,
> "Failed to register partner on port: %d\n",
> port_num);
> --
> 2.26.1.301.g55bc3eb7cb9-goog
>

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]

---

Attachments:

(No filename) (1.27 kB)
signature.asc (235.00 B)
Download all attachments