arch/arm/boot/dts/uniphier-ref-daughter.dtsi has
compatible = "microchip,24lc128", "atmel,24c128";
and 'make ARCH=arm dtbs_check' warns this:
eeprom@50: compatible: ['microchip,24lc128', 'atmel,24c128'] is not valid under any of the given schemas (Possible causes of the failure)
Microchip 24LC128 is the device used on this board, and I see it in
https://www.microchip.com/wwwproducts/en/24LC128
Signed-off-by: Masahiro Yamada <[email protected]>
---
Documentation/devicetree/bindings/eeprom/at24.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index a15787e504f0..2cd7a04cab7c 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -34,7 +34,7 @@ properties:
- minItems: 1
maxItems: 2
items:
- - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|mac)[0-9]+|spd)$"
+ - pattern: "^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$"
- pattern: "^atmel,(24(c|cs|mac)[0-9]+|spd)$"
- oneOf:
- items:
--
2.25.1
On Wed, 22 Apr 2020 23:18:36 +0900, Masahiro Yamada wrote:
> arch/arm/boot/dts/uniphier-ref-daughter.dtsi has
>
> compatible = "microchip,24lc128", "atmel,24c128";
>
> and 'make ARCH=arm dtbs_check' warns this:
>
> eeprom@50: compatible: ['microchip,24lc128', 'atmel,24c128'] is not valid under any of the given schemas (Possible causes of the failure)
>
> Microchip 24LC128 is the device used on this board, and I see it in
> https://www.microchip.com/wwwproducts/en/24LC128
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> Documentation/devicetree/bindings/eeprom/at24.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
Hi Rob,
On Tue, May 12, 2020 at 4:14 AM Rob Herring <[email protected]> wrote:
>
> On Wed, 22 Apr 2020 23:18:36 +0900, Masahiro Yamada wrote:
> > arch/arm/boot/dts/uniphier-ref-daughter.dtsi has
> >
> > compatible = "microchip,24lc128", "atmel,24c128";
> >
> > and 'make ARCH=arm dtbs_check' warns this:
> >
> > eeprom@50: compatible: ['microchip,24lc128', 'atmel,24c128'] is not valid under any of the given schemas (Possible causes of the failure)
> >
> > Microchip 24LC128 is the device used on this board, and I see it in
> > https://www.microchip.com/wwwproducts/en/24LC128
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > Documentation/devicetree/bindings/eeprom/at24.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Applied, thanks!
If it is not too late, can you correct the patch subject?
See the applied commit in linux-next.
Author: Masahiro Yamada <[email protected]>
Date: Wed Apr 22 23:18:36 2020 +0900
dt-bindings: at24: add microchip, 24lc[0-9]+ to the compatible pattern
Please notice a space after 'microchip,'
And this is the patch I submitted:
https://lore.kernel.org/patchwork/patch/1229480/
No space after 'microchip,'
This is a patchwork bug.
It automatically inserts a space after a comma.
Patchwork adds various unpleasant modification,
and breaks the commit subject and log.
I reported this bug to patchwork ML, but
still not fixed...
--
Best Regards
Masahiro Yamada