2020-04-24 03:18:32

by Chen Tao

Subject: [PATCH] drm: amdgpu: Move static inline keyword to the front of declarations

Fix the following warning:

Move the static inline keyword to the front of declarations
amdgpu_device_wreg_no_kiq, and resolve the following
compiler warnings that can be seen when building
with warnings enabled (W=1):

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
‘static’ is not at beginning of declaration
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
‘inline’ is not at beginning of declaration

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: ChenTao <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index ad1c66763dc1..d53a5e3f464b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -341,7 +341,7 @@ void amdgpu_mm_wreg8(struct amdgpu_device *adev, uint32_t offset, uint8_t value)
BUG();
}

-void static inline amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
+static inline void amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
uint32_t v, uint32_t acc_flags)
{
trace_amdgpu_device_wreg(adev->pdev->device, reg, v);
--
2.17.1

2020-04-24 07:43:28

by Christian König

Subject: Re: [PATCH] drm: amdgpu: Move static inline keyword to the front of declarations

Am 24.04.20 um 05:13 schrieb ChenTao:
> Fix the following warning:
>
> Move the static inline keyword to the front of declarations
> amdgpu_device_wreg_no_kiq, and resolve the following
> compiler warnings that can be seen when building
> with warnings enabled (W=1):
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
> ‘static’ is not at beginning of declaration
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:344:1:warning:
> ‘inline’ is not at beginning of declaration
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: ChenTao <[email protected]>

Reviewed-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index ad1c66763dc1..d53a5e3f464b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -341,7 +341,7 @@ void amdgpu_mm_wreg8(struct amdgpu_device *adev, uint32_t offset, uint8_t value)
> BUG();
> }
>
> -void static inline amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
> +static inline void amdgpu_device_wreg_no_kiq(struct amdgpu_device *adev, uint32_t reg,
> uint32_t v, uint32_t acc_flags)
> {
> trace_amdgpu_device_wreg(adev->pdev->device, reg, v);