2020-04-20 04:03:49

by Jason Yan

[permalink] [raw]

Subject: [PATCH] i2c: busses: remove unneeded conversion to bool

---

The '>' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

drivers/i2c/busses/i2c-qup.c:960:48-53: WARNING: conversion to bool not needed here
drivers/i2c/busses/i2c-qup.c:962:47-52: WARNING: conversion to bool not needed here
drivers/i2c/busses/i2c-qup.c:1531:29-34: WARNING: conversion to bool not needed here
drivers/i2c/busses/i2c-qup.c:1533:29-34: WARNING: conversion to bool not needed here

Signed-off-by: Jason Yan <[email protected]>
---
drivers/i2c/busses/i2c-qup.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index 155dcde70fc9..25d5fe2f8316 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -956,10 +956,8 @@ static void qup_i2c_conf_v1(struct qup_i2c_dev *qup)
u32 qup_config = I2C_MINI_CORE | I2C_N_VAL;
u32 io_mode = QUP_REPACK_EN;

- blk->is_tx_blk_mode =
- blk->total_tx_len > qup->out_fifo_sz ? true : false;
- blk->is_rx_blk_mode =
- blk->total_rx_len > qup->in_fifo_sz ? true : false;
+ blk->is_tx_blk_mode = blk->total_tx_len > qup->out_fifo_sz;
+ blk->is_rx_blk_mode = blk->total_rx_len > qup->in_fifo_sz;

if (blk->is_tx_blk_mode) {
io_mode |= QUP_OUTPUT_BLK_MODE;
@@ -1528,9 +1526,9 @@ qup_i2c_determine_mode_v2(struct qup_i2c_dev *qup,
qup->use_dma = true;
} else {
qup->blk.is_tx_blk_mode = max_tx_len > qup->out_fifo_sz -
- QUP_MAX_TAGS_LEN ? true : false;
+ QUP_MAX_TAGS_LEN;
qup->blk.is_rx_blk_mode = max_rx_len > qup->in_fifo_sz -
- READ_RX_TAGS_LEN ? true : false;
+ READ_RX_TAGS_LEN;
}

return 0;
--
2.21.1

2020-04-20 04:45:51

by Bjorn Andersson

[permalink] [raw]

Subject: Re: [PATCH] i2c: busses: remove unneeded conversion to bool

---

On Sun 19 Apr 21:28 PDT 2020, Jason Yan wrote:

> The '>' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/i2c/busses/i2c-qup.c:960:48-53: WARNING: conversion to bool not needed here
> drivers/i2c/busses/i2c-qup.c:962:47-52: WARNING: conversion to bool not needed here
> drivers/i2c/busses/i2c-qup.c:1531:29-34: WARNING: conversion to bool not needed here
> drivers/i2c/busses/i2c-qup.c:1533:29-34: WARNING: conversion to bool not needed here
>
> Signed-off-by: Jason Yan <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

> ---
> drivers/i2c/busses/i2c-qup.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
> index 155dcde70fc9..25d5fe2f8316 100644
> --- a/drivers/i2c/busses/i2c-qup.c
> +++ b/drivers/i2c/busses/i2c-qup.c
> @@ -956,10 +956,8 @@ static void qup_i2c_conf_v1(struct qup_i2c_dev *qup)
> u32 qup_config = I2C_MINI_CORE | I2C_N_VAL;
> u32 io_mode = QUP_REPACK_EN;
>
> - blk->is_tx_blk_mode =
> - blk->total_tx_len > qup->out_fifo_sz ? true : false;
> - blk->is_rx_blk_mode =
> - blk->total_rx_len > qup->in_fifo_sz ? true : false;
> + blk->is_tx_blk_mode = blk->total_tx_len > qup->out_fifo_sz;
> + blk->is_rx_blk_mode = blk->total_rx_len > qup->in_fifo_sz;
>
> if (blk->is_tx_blk_mode) {
> io_mode |= QUP_OUTPUT_BLK_MODE;
> @@ -1528,9 +1526,9 @@ qup_i2c_determine_mode_v2(struct qup_i2c_dev *qup,
> qup->use_dma = true;
> } else {
> qup->blk.is_tx_blk_mode = max_tx_len > qup->out_fifo_sz -
> - QUP_MAX_TAGS_LEN ? true : false;
> + QUP_MAX_TAGS_LEN;
> qup->blk.is_rx_blk_mode = max_rx_len > qup->in_fifo_sz -
> - READ_RX_TAGS_LEN ? true : false;
> + READ_RX_TAGS_LEN;
> }
>
> return 0;
> --
> 2.21.1
>

2020-04-26 08:18:54

by Wolfram Sang

[permalink] [raw]

Subject: Re: [PATCH] i2c: busses: remove unneeded conversion to bool

---

On Mon, Apr 20, 2020 at 12:28:16PM +0800, Jason Yan wrote:
> The '>' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/i2c/busses/i2c-qup.c:960:48-53: WARNING: conversion to bool not needed here
> drivers/i2c/busses/i2c-qup.c:962:47-52: WARNING: conversion to bool not needed here
> drivers/i2c/busses/i2c-qup.c:1531:29-34: WARNING: conversion to bool not needed here
> drivers/i2c/busses/i2c-qup.c:1533:29-34: WARNING: conversion to bool not needed here
>
> Signed-off-by: Jason Yan <[email protected]>

Applied to for-next, thanks! But please fix $subject to have the driver
name "qup" next time.

---

Attachments:

(No filename) (691.00 B)
signature.asc (849.00 B)
Download all attachments

2020-04-26 08:48:04

by Jason Yan

[permalink] [raw]

Subject: Re: [PATCH] i2c: busses: remove unneeded conversion to bool

---

在 2020/4/26 16:16, Wolfram Sang 写道:
> On Mon, Apr 20, 2020 at 12:28:16PM +0800, Jason Yan wrote:
>> The '>' expression itself is bool, no need to convert it to bool again.
>> This fixes the following coccicheck warning:
>>
>> drivers/i2c/busses/i2c-qup.c:960:48-53: WARNING: conversion to bool not needed here
>> drivers/i2c/busses/i2c-qup.c:962:47-52: WARNING: conversion to bool not needed here
>> drivers/i2c/busses/i2c-qup.c:1531:29-34: WARNING: conversion to bool not needed here
>> drivers/i2c/busses/i2c-qup.c:1533:29-34: WARNING: conversion to bool not needed here
>>
>> Signed-off-by: Jason Yan <[email protected]>
>
> Applied to for-next, thanks! But please fix $subject to have the driver
> name "qup" next time.
>

OK, get it.

Thanks,
Jason