2020-04-27 06:42:16

by Jason Yan

Subject: [PATCH] drm/amd/display: remove conversion to bool in dc_link_ddc.c

The '>' expression itself is bool, no need to convert it to bool again.
This fixes the following coccicheck warning:

drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:602:28-33: WARNING:
conversion to bool not needed here

Signed-off-by: Jason Yan <[email protected]>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
index 256889eed93e..aefd29a440b5 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
@@ -599,7 +599,7 @@ bool dal_ddc_submit_aux_command(struct ddc_service *ddc,
do {
struct aux_payload current_payload;
bool is_end_of_payload = (retrieved + DEFAULT_AUX_MAX_DATA_SIZE) >
- payload->length ? true : false;
+ payload->length;

current_payload.address = payload->address;
current_payload.data = &payload->data[retrieved];
--
2.21.1

2020-04-27 08:06:03

by Christian König

Subject: Re: [PATCH] drm/amd/display: remove conversion to bool in dc_link_ddc.c

Am 27.04.20 um 08:37 schrieb Jason Yan:
> The '>' expression itself is bool, no need to convert it to bool again.
> This fixes the following coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:602:28-33: WARNING:
> conversion to bool not needed here
>
> Signed-off-by: Jason Yan <[email protected]>

Reviewed-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> index 256889eed93e..aefd29a440b5 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> @@ -599,7 +599,7 @@ bool dal_ddc_submit_aux_command(struct ddc_service *ddc,
> do {
> struct aux_payload current_payload;
> bool is_end_of_payload = (retrieved + DEFAULT_AUX_MAX_DATA_SIZE) >
> - payload->length ? true : false;
> + payload->length;
>
> current_payload.address = payload->address;
> current_payload.data = &payload->data[retrieved];

2020-04-27 19:36:30

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: remove conversion to bool in dc_link_ddc.c

Applied. Thanks!

Alex

On Mon, Apr 27, 2020 at 4:03 AM Christian König
<[email protected]> wrote:
>
> Am 27.04.20 um 08:37 schrieb Jason Yan:
> > The '>' expression itself is bool, no need to convert it to bool again.
> > This fixes the following coccicheck warning:
> >
> > drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:602:28-33: WARNING:
> > conversion to bool not needed here
> >
> > Signed-off-by: Jason Yan <[email protected]>
>
> Reviewed-by: Christian König <[email protected]>
>
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> > index 256889eed93e..aefd29a440b5 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
> > @@ -599,7 +599,7 @@ bool dal_ddc_submit_aux_command(struct ddc_service *ddc,
> > do {
> > struct aux_payload current_payload;
> > bool is_end_of_payload = (retrieved + DEFAULT_AUX_MAX_DATA_SIZE) >
> > - payload->length ? true : false;
> > + payload->length;
> >
> > current_payload.address = payload->address;
> > current_payload.data = &payload->data[retrieved];
>
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx