2020-04-30 06:57:41

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH v3 5/7] tty: Add NOKERNINFO lflag to termios

On 30. 04. 20, 8:42, Arseny Maslennikov wrote:
> The termios lflag is off by default.

This commit message is too poor. Describing the intended use would help.

thanks,
--
js
suse labs


2020-04-30 07:22:13

by Arseny Maslennikov

[permalink] [raw]
Subject: Re: [PATCH v3 5/7] tty: Add NOKERNINFO lflag to termios

On Thu, Apr 30, 2020 at 08:55:43AM +0200, Jiri Slaby wrote:
> On 30. 04. 20, 8:42, Arseny Maslennikov wrote:
> > The termios lflag is off by default.
>
> This commit message is too poor. Describing the intended use would help.
>

I described its use in the last patch of the series, where it actually
gains some use.

I agree, however, that the limited explanation in this commit does not
look helpful at all when looking at e.g. git blame output.

I'll resend a v4 with this commit message improved.


Attachments:
(No filename) (517.00 B)
signature.asc (849.00 B)
Download all attachments