2020-05-07 11:23:00

by Po Liu

Subject: [net-next] net:enetc: bug fix for qos sfi operate space after freed

'Dan Carpenter' reported:
This code frees "sfi" and then dereferences it on the next line:
> kfree(sfi);
> clear_bit(sfi->index, epsfp.psfp_sfi_bitmap);

This "sfi->index" should be "index".

Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Po Liu <[email protected]>
---
drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index 48e589e9d0f7..77f110e24505 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -903,7 +903,7 @@ static void stream_filter_unref(struct enetc_ndev_priv *priv, u32 index)
enetc_streamfilter_hw_set(priv, sfi, false);
hlist_del(&sfi->node);
kfree(sfi);
- clear_bit(sfi->index, epsfp.psfp_sfi_bitmap);
+ clear_bit(index, epsfp.psfp_sfi_bitmap);
}
}

--
2.17.1

2020-05-07 20:08:25

by David Miller

Subject: Re: [net-next] net:enetc: bug fix for qos sfi operate space after freed

From: Po Liu <[email protected]>
Date: Thu, 7 May 2020 18:57:38 +0800

> 'Dan Carpenter' reported:
> This code frees "sfi" and then dereferences it on the next line:
>> kfree(sfi);
>> clear_bit(sfi->index, epsfp.psfp_sfi_bitmap);
>
> This "sfi->index" should be "index".
>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Po Liu <[email protected]>

Applied.