2020-05-13 20:45:12

by Tang Bin

Subject: [PATCH v2] USB: host: ehci-mxc: Add error handling in ehci_mxc_drv_probe()

The function ehci_mxc_drv_probe() does not perform sufficient error
checking after executing platform_get_irq(), thus fix it.

Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards")
Signed-off-by: Zhang Shengju <[email protected]>
Signed-off-by: Tang Bin <[email protected]>
---
Changes from v1
- fix the subject.
---
drivers/usb/host/ehci-mxc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index c9f91e6c7..7f65c8604 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
}

irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return irq;

hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev));
if (!hcd)
--
2.20.1.windows.1

2020-05-14 02:53:24

by Peter Chen

Subject: Re: [PATCH v2] USB: host: ehci-mxc: Add error handling in ehci_mxc_drv_probe()

On 20-05-13 21:26:47, Tang Bin wrote:
> The function ehci_mxc_drv_probe() does not perform sufficient error
> checking after executing platform_get_irq(), thus fix it.
>
> Fixes: 7e8d5cd93fa ("USB: Add EHCI support for MX27 and MX31 based boards")
> Signed-off-by: Zhang Shengju <[email protected]>
> Signed-off-by: Tang Bin <[email protected]>
> ---
> Changes from v1
> - fix the subject.
> ---
> drivers/usb/host/ehci-mxc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index c9f91e6c7..7f65c8604 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> + if (irq < 0)
> + return irq;
>
> hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev));
> if (!hcd)
> --

Reviewed-by: Peter Chen <[email protected]>

--

Thanks,
Peter Chen