2020-04-16 01:51:54

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

It is a logical continuation of previously applied %ptR for struct rtc_time.
We have few users of time64_t that would like to print it.

Andrew, since Petr can't pay attention on this perhaps it can be passed thru
your tree?

Sergey, Steven, what do you think?

In v3:
- added tag (Alexandre)
- dropped for now USB Tegra patch (Thierry wasn't clear about)

In v2:
- drop #ifdef CONFIG_RTC_LIB with time64_to_rtc_time() altogether
(Petr, Alexandre)
- update default error path message along with test case for it
- add Hans' Ack for patch 3

Andy Shevchenko (3):
lib/vsprintf: Print time64_t in human readable format
ARM: bcm2835: Switch to use %ptT
[media] usb: pulse8-cec: Switch to use %ptT

Documentation/core-api/printk-formats.rst | 22 ++++++++--------
drivers/firmware/raspberrypi.c | 12 +++------
drivers/media/usb/pulse8-cec/pulse8-cec.c | 6 +----
lib/test_printf.c | 13 +++++++---
lib/vsprintf.c | 31 +++++++++++++++++++++--
5 files changed, 55 insertions(+), 29 deletions(-)

--
2.25.1


2020-05-15 16:06:55

by Petr Mladek

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

On Wed 2020-04-15 20:00:43, Andy Shevchenko wrote:
> It is a logical continuation of previously applied %ptR for struct rtc_time.
> We have few users of time64_t that would like to print it.

It seems that everything was explained and the patches look good to
me. If we allowed %ptR then it makes sense to allow %ptT as well.

For all three patches:

Rewieved-by: Petr Mladek <[email protected]>

Best Regards,
Petr

2020-05-20 11:46:01

by Sergey Senozhatsky

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

On (20/05/15 18:02), Petr Mladek wrote:
> On Wed 2020-04-15 20:00:43, Andy Shevchenko wrote:
> > It is a logical continuation of previously applied %ptR for struct rtc_time.
> > We have few users of time64_t that would like to print it.
>
> It seems that everything was explained and the patches look good to
> me. If we allowed %ptR then it makes sense to allow %ptT as well.
>
> For all three patches:
>
> Rewieved-by: Petr Mladek <[email protected]>

Acked-by: Sergey Senozhatsky <[email protected]>

-ss

2020-05-21 08:49:06

by Petr Mladek

[permalink] [raw]
Subject: Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

On Wed 2020-05-20 20:43:33, Sergey Senozhatsky wrote:
> On (20/05/15 18:02), Petr Mladek wrote:
> > On Wed 2020-04-15 20:00:43, Andy Shevchenko wrote:
> > > It is a logical continuation of previously applied %ptR for struct rtc_time.
> > > We have few users of time64_t that would like to print it.
> >
> > It seems that everything was explained and the patches look good to
> > me. If we allowed %ptR then it makes sense to allow %ptT as well.
> >
> > For all three patches:
> >
> > Rewieved-by: Petr Mladek <[email protected]>
>
> Acked-by: Sergey Senozhatsky <[email protected]>

This patchset has been committed into printk/linux.git,
branch for-5.8-printf-time64_t.

Note that it is a new git repo with shared write access.

Best Regards,
Petr