LinuxLists.cc - [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

2020-04-29 10:10:54

Subject: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

From: Fugang Duan <[email protected]>

Add "fsl,imx6sx-fec" compatible string for fec node, then
i.MX8MP EVK ethernet function can work now.

Signed-off-by: Fugang Duan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 9b1616e59d58..b5df957c5063 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -615,7 +615,7 @@
};

fec: ethernet@30be0000 {
- compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
+ compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec", "fsl,imx6sx-fec";
reg = <0x30be0000 0x10000>;
interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
--
2.17.1

2020-04-29 10:14:59

by Aisheng Dong

[permalink] [raw]

Subject: RE: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

> From: Andy Duan <[email protected]>
> Sent: Wednesday, April 29, 2020 6:04 PM
>
> Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK ethernet
> function can work now.
>
> Signed-off-by: Fugang Duan <[email protected]>

Reviewed-by: Dong Aisheng <[email protected]>

Regards
Aisheng

> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
> };
>
> fec: ethernet@30be0000 {
> - compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> + compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec",
> "fsl,imx6sx-fec";
> reg = <0x30be0000 0x10000>;
> interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1

2020-05-13 08:52:15

by Shawn Guo

[permalink] [raw]

Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

On Wed, Apr 29, 2020 at 06:04:14PM +0800, [email protected] wrote:
> From: Fugang Duan <[email protected]>
>
> Add "fsl,imx6sx-fec" compatible string for fec node, then
> i.MX8MP EVK ethernet function can work now.
>
> Signed-off-by: Fugang Duan <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 9b1616e59d58..b5df957c5063 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -615,7 +615,7 @@
> };
>
> fec: ethernet@30be0000 {
> - compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec";
> + compatible = "fsl,imx8mp-fec", "fsl,imx8mq-fec", "fsl,imx6sx-fec";

In this case, "fsl,imx8mq-fec" can be dropped?

Shawn

> reg = <0x30be0000 0x10000>;
> interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1
>

2020-05-13 09:01:03

by Andy Duan

[permalink] [raw]

Subject: RE: [EXT] Re: [PATCH 1/1] arm64: dts: imx8mp: add "fsl,imx6sx-fec" compatible string

From: Shawn Guo <[email protected]> Sent: Wednesday, May 13, 2020 4:50 PM
> On Wed, Apr 29, 2020 at 06:04:14PM +0800, [email protected] wrote:
> > From: Fugang Duan <[email protected]>
> >
> > Add "fsl,imx6sx-fec" compatible string for fec node, then i.MX8MP EVK
> > ethernet function can work now.
> >
> > Signed-off-by: Fugang Duan <[email protected]>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index 9b1616e59d58..b5df957c5063 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -615,7 +615,7 @@
> > };
> >
> > fec: ethernet@30be0000 {
> > - compatible = "fsl,imx8mp-fec",
> "fsl,imx8mq-fec";
> > + compatible = "fsl,imx8mp-fec",
> > + "fsl,imx8mq-fec", "fsl,imx6sx-fec";
>
> In this case, "fsl,imx8mq-fec" can be dropped?
>
> Shawn
Please don't drop the compatible string, there have little difference for 8mq
that support eee feature, the feature will be upstreamed.

Thanks.
>
> > reg = <0x30be0000 0x10000>;
> > interrupts = <GIC_SPI 118
> IRQ_TYPE_LEVEL_HIGH>,
> > <GIC_SPI 119
> > IRQ_TYPE_LEVEL_HIGH>,
> > --
> > 2.17.1
> >

2020-05-17 14:18:11

by Shawn Guo

[permalink] [raw]