2020-05-28 09:20:07

by Arnd Bergmann

Subject: [PATCH] btrfs: select FS_IOMAP

As btrfs now calls iomap_dio_rw, the helper code actually has
to be enabled to avoid a link error:

ERROR: modpost: "iomap_dio_rw" [fs/btrfs/btrfs.ko] undefined!

Fixes: f31e5f70919f ("btrfs: switch to iomap_dio_rw() for dio")
Signed-off-by: Arnd Bergmann <[email protected]>
---
fs/btrfs/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 575636f6491e..68b95ad82126 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -14,6 +14,7 @@ config BTRFS_FS
select LZO_DECOMPRESS
select ZSTD_COMPRESS
select ZSTD_DECOMPRESS
+ select FS_IOMAP
select RAID6_PQ
select XOR_BLOCKS
select SRCU
--
2.26.2

2020-05-28 09:22:23

by Johannes Thumshirn

Subject: Re: [PATCH] btrfs: select FS_IOMAP

Right,
Reviewed-by: Johannes Thumshirn <[email protected]>

2020-05-28 12:10:16

by David Sterba

Subject: Re: [PATCH] btrfs: select FS_IOMAP

On Thu, May 28, 2020 at 11:16:42AM +0200, Arnd Bergmann wrote:
> As btrfs now calls iomap_dio_rw, the helper code actually has
> to be enabled to avoid a link error:
>
> ERROR: modpost: "iomap_dio_rw" [fs/btrfs/btrfs.ko] undefined!
>
> Fixes: f31e5f70919f ("btrfs: switch to iomap_dio_rw() for dio")
> Signed-off-by: Arnd Bergmann <[email protected]>

Thanks, I've folded the patch in so we don't get build breakage in the
patches between the two.