2020-06-03 12:00:30

by Chuhong Yuan

Subject: [PATCH] media: marvell-ccic: Add missed v4l2_async_notifier_cleanup()

mccic_register() forgets to cleanup the notifier in its error handler.
Add the missed call to fix it.

Fixes: 3eefe36cc00c ("media: marvell-ccic: use async notifier to get the sensor")
Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/media/platform/marvell-ccic/mcam-core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
index 09775b6624c6..cf2a0119e679 100644
--- a/drivers/media/platform/marvell-ccic/mcam-core.c
+++ b/drivers/media/platform/marvell-ccic/mcam-core.c
@@ -1940,6 +1940,7 @@ int mccic_register(struct mcam_camera *cam)
out:
v4l2_async_notifier_unregister(&cam->notifier);
v4l2_device_unregister(&cam->v4l2_dev);
+ v4l2_async_notifier_cleanup(&cam->notifier);
return ret;
}
EXPORT_SYMBOL_GPL(mccic_register);
--
2.26.2

2020-06-03 12:46:35

by Sakari Ailus

Subject: Re: [PATCH] media: marvell-ccic: Add missed v4l2_async_notifier_cleanup()

Hi Chuhong,

Thanks for the patch.

On Wed, Jun 03, 2020 at 07:56:05PM +0800, Chuhong Yuan wrote:
> mccic_register() forgets to cleanup the notifier in its error handler.
> Add the missed call to fix it.
>
> Fixes: 3eefe36cc00c ("media: marvell-ccic: use async notifier to get the sensor")
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> drivers/media/platform/marvell-ccic/mcam-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
> index 09775b6624c6..cf2a0119e679 100644
> --- a/drivers/media/platform/marvell-ccic/mcam-core.c
> +++ b/drivers/media/platform/marvell-ccic/mcam-core.c
> @@ -1940,6 +1940,7 @@ int mccic_register(struct mcam_camera *cam)
> out:
> v4l2_async_notifier_unregister(&cam->notifier);
> v4l2_device_unregister(&cam->v4l2_dev);
> + v4l2_async_notifier_cleanup(&cam->notifier);
> return ret;
> }
> EXPORT_SYMBOL_GPL(mccic_register);

The same issue appears to be present in the mcam_shutdown(), could you fix
that one as well?

--
Regards,

Sakari Ailus