2020-06-11 17:37:58

by Colin King

Subject: [PATCH] pktcdvd: remove redundant initialization of variable ret

From: Colin Ian King <[email protected]>

The variable ret is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/block/pktcdvd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index 0b944ac96d6b..27a33adc41e4 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -1613,7 +1613,7 @@ static noinline_for_stack int pkt_get_last_written(struct pktcdvd_device *pd,
disc_information di;
track_information ti;
__u32 last_track;
- int ret = -1;
+ int ret;

ret = pkt_get_disc_info(pd, &di);
if (ret)
--
2.27.0.rc0

2020-06-11 17:41:11

by Jens Axboe

Subject: Re: [PATCH] pktcdvd: remove redundant initialization of variable ret

On 6/11/20 8:30 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable ret is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.

Applied, thanks.

--
Jens Axboe