2020-06-22 09:17:56

by FLAVIO SULIGOI

Subject: [PATCH v1 1/1] pci: controller: cadence: fix wrong path in comment

This comment still refers to the old driver pathname,
when all PCI drivers were located directly under the
drivers/pci directory.

Anyway the function name itself is enough, so we can
remove the overabundant path reference.

Signed-off-by: Flavio Suligoi <[email protected]>
Acked-by: Bjorn Helgaas <[email protected]>
---

v1: - after the suggestion of Bjorn, remove the whole comment line related to
the wrong path
- add: Acked-by: Bjorn Helgaas <[email protected]>

drivers/pci/controller/cadence/pcie-cadence-ep.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
index 1c15c8352125..690eefd328ea 100644
--- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
+++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
@@ -276,7 +276,6 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
cdns_pcie_ep_assert_intx(ep, fn, intx, true);
/*
* The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
- * from drivers/pci/dwc/pci-dra7xx.c
*/
mdelay(1);
cdns_pcie_ep_assert_intx(ep, fn, intx, false);
--
2.17.1

2020-06-22 16:57:44

by Bjorn Helgaas

Subject: Re: [PATCH v1 1/1] pci: controller: cadence: fix wrong path in comment

Please use "git log --oneline" to help construct the subject line.
Maybe:

PCI: cadence-ep: Remove obsolete path from comment

On Mon, Jun 22, 2020 at 11:15:20AM +0200, Flavio Suligoi wrote:
> This comment still refers to the old driver pathname,
> when all PCI drivers were located directly under the
> drivers/pci directory.
>
> Anyway the function name itself is enough, so we can
> remove the overabundant path reference.
>
> Signed-off-by: Flavio Suligoi <[email protected]>
> Acked-by: Bjorn Helgaas <[email protected]>

I did not ack this. Please don't add acks unless someone does so
explicitly.

> ---
>
> v1: - after the suggestion of Bjorn, remove the whole comment line related to
> the wrong path
> - add: Acked-by: Bjorn Helgaas <[email protected]>
>
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> index 1c15c8352125..690eefd328ea 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> @@ -276,7 +276,6 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
> cdns_pcie_ep_assert_intx(ep, fn, intx, true);
> /*
> * The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
> - * from drivers/pci/dwc/pci-dra7xx.c
> */
> mdelay(1);
> cdns_pcie_ep_assert_intx(ep, fn, intx, false);
> --
> 2.17.1
>