2020-06-22 15:49:50

by Luc Van Oostenryck

Subject: [PATCH] kbuild: run the checker after the compiler

Since the pre-git time the checker is run first, before the compiler.
But if the source file contains some syntax error, the warnings from
the compiler are more useful than those from sparse (and other
checker most probably too).

So move the 'check' command to run after the compiler.

Signed-off-by: Luc Van Oostenryck <[email protected]>
---
scripts/Makefile.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 2e8810b7e5ed..7ba6a752d5bd 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -252,9 +252,9 @@ cmd_gen_ksymdeps = \
endif

define rule_cc_o_c
- $(call cmd,checksrc)
$(call cmd_and_fixdep,cc_o_c)
$(call cmd,gen_ksymdeps)
+ $(call cmd,checksrc)
$(call cmd,checkdoc)
$(call cmd,objtool)
$(call cmd,modversions_c)
@@ -277,8 +277,8 @@ endif

# Built-in and composite module parts
$(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
- $(call cmd,force_checksrc)
$(call if_changed_rule,cc_o_c)
+ $(call cmd,force_checksrc)

cmd_mod = { \
echo $(if $($*-objs)$($*-y)$($*-m), $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), $(@:.mod=.o)); \

base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110
--
2.27.0

2020-06-23 06:02:20

by Masahiro Yamada

Subject: Re: [PATCH] kbuild: run the checker after the compiler

On Tue, Jun 23, 2020 at 12:47 AM Luc Van Oostenryck
<[email protected]> wrote:
>
> Since the pre-git time the checker is run first, before the compiler.
> But if the source file contains some syntax error, the warnings from
> the compiler are more useful than those from sparse (and other
> checker most probably too).
>
> So move the 'check' command to run after the compiler.
>
> Signed-off-by: Luc Van Oostenryck <[email protected]>

Applied to linux-kbuild.
Thanks.

> ---
> scripts/Makefile.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 2e8810b7e5ed..7ba6a752d5bd 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -252,9 +252,9 @@ cmd_gen_ksymdeps = \
> endif
>
> define rule_cc_o_c
> - $(call cmd,checksrc)
> $(call cmd_and_fixdep,cc_o_c)
> $(call cmd,gen_ksymdeps)
> + $(call cmd,checksrc)
> $(call cmd,checkdoc)
> $(call cmd,objtool)
> $(call cmd,modversions_c)
> @@ -277,8 +277,8 @@ endif
>
> # Built-in and composite module parts
> $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
> - $(call cmd,force_checksrc)
> $(call if_changed_rule,cc_o_c)
> + $(call cmd,force_checksrc)
>
> cmd_mod = { \
> echo $(if $($*-objs)$($*-y)$($*-m), $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), $(@:.mod=.o)); \
>
> base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110
> --
> 2.27.0
>


--
Best Regards
Masahiro Yamada