2020-07-01 15:19:59

by Wei Yongjun

Subject: [PATCH -next] f2fs: make __allocate_new_segment() static

From: Hulk Robot <[email protected]>

From: Hulk Robot <[email protected]>

Fix sparse build warning:

fs/f2fs/segment.c:2736:6: warning:
symbol '__allocate_new_segment' was not declared. Should it be static?

Signed-off-by: Hulk Robot <[email protected]>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index b45e473508a9..c35614d255e1 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2733,7 +2733,7 @@ void f2fs_allocate_segment_for_resize(struct f2fs_sb_info *sbi, int type,
up_read(&SM_I(sbi)->curseg_lock);
}

-void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
+static void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
{
struct curseg_info *curseg = CURSEG_I(sbi, type);
unsigned int old_segno;

2020-07-01 16:19:19

by Jaegeuk Kim

Subject: Re: [PATCH -next] f2fs: make __allocate_new_segment() static

On 07/01, Wei Yongjun wrote:
> From: Hulk Robot <[email protected]>
>
> From: Hulk Robot <[email protected]>
>
> Fix sparse build warning:
>
> fs/f2fs/segment.c:2736:6: warning:
> symbol '__allocate_new_segment' was not declared. Should it be static?

It was fixed.
https://lore.kernel.org/linux-f2fs-devel/[email protected]/T/#m9667447e4d37672e26dee7e30896d129eac1c479

>
> Signed-off-by: Hulk Robot <[email protected]>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index b45e473508a9..c35614d255e1 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2733,7 +2733,7 @@ void f2fs_allocate_segment_for_resize(struct f2fs_sb_info *sbi, int type,
> up_read(&SM_I(sbi)->curseg_lock);
> }
>
> -void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> +static void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> {
> struct curseg_info *curseg = CURSEG_I(sbi, type);
> unsigned int old_segno;