2020-07-03 04:58:11

by Wei Yongjun

Subject: [PATCH -next] locktorture: make function torture_percpu_rwsem_init() static

The sparse tool complains as follows:

kernel/locking/locktorture.c:569:6: warning:
symbol 'torture_percpu_rwsem_init' was not declared. Should it be static?

And this function is not used outside of locktorture.c,
so this commit marks it static.

Signed-off-by: Wei Yongjun <[email protected]>
---
kernel/locking/locktorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index 9cfa5e89cff7..62d215b2e39f 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -566,7 +566,7 @@ static struct lock_torture_ops rwsem_lock_ops = {
#include <linux/percpu-rwsem.h>
static struct percpu_rw_semaphore pcpu_rwsem;

-void torture_percpu_rwsem_init(void)
+static void torture_percpu_rwsem_init(void)
{
BUG_ON(percpu_init_rwsem(&pcpu_rwsem));
}

2020-07-06 22:55:55

by Paul E. McKenney

Subject: Re: [PATCH -next] locktorture: make function torture_percpu_rwsem_init() static

On Fri, Jul 03, 2020 at 01:05:27PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> kernel/locking/locktorture.c:569:6: warning:
> symbol 'torture_percpu_rwsem_init' was not declared. Should it be static?
>
> And this function is not used outside of locktorture.c,
> so this commit marks it static.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Applied, thank you!!!

Thanx, Paul

> ---
> kernel/locking/locktorture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
> index 9cfa5e89cff7..62d215b2e39f 100644
> --- a/kernel/locking/locktorture.c
> +++ b/kernel/locking/locktorture.c
> @@ -566,7 +566,7 @@ static struct lock_torture_ops rwsem_lock_ops = {
> #include <linux/percpu-rwsem.h>
> static struct percpu_rw_semaphore pcpu_rwsem;
>
> -void torture_percpu_rwsem_init(void)
> +static void torture_percpu_rwsem_init(void)
> {
> BUG_ON(percpu_init_rwsem(&pcpu_rwsem));
> }
>