2020-07-07 07:47:54

by Ran Wang

Subject: [PATCH] arm64: dts: ls1043a: update USB nodes status to match board config

ls1043a-rdb and ls1043a-qds board’s default HW config (such as
pin mux selection) would not enable some USB controllers’
data path, which causing over-current detected on those
controllers. This will hit the case of ‘xhci driver prevent bus suspend
if a root hub port detected over-current condition’, causing system
failed to be suspended. So disable them in device tree to resolve this
issue.

Signed-off-by: Ran Wang <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 4 ++++
arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 8 ++++++++
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 3 +++
3 files changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
index 1aac81d..fea167d 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
@@ -148,4 +148,8 @@
};
};

+&usb0 {
+ status = "okay";
+};
+
#include "fsl-ls1043-post.dtsi"
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
index bfa9d95..3516af4 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts
@@ -209,3 +209,11 @@
fsl,tdm-interface;
};
};
+
+&usb0 {
+ status = "okay";
+};
+
+&usb1 {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 3b641bd..c6d8dcb 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -677,6 +677,7 @@
snps,quirk-frame-length-adjustment = <0x20>;
snps,dis_rxdet_inp3_quirk;
snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+ status = "disabled";
};

usb1: usb3@3000000 {
@@ -687,6 +688,7 @@
snps,quirk-frame-length-adjustment = <0x20>;
snps,dis_rxdet_inp3_quirk;
snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+ status = "disabled";
};

usb2: usb3@3100000 {
@@ -697,6 +699,7 @@
snps,quirk-frame-length-adjustment = <0x20>;
snps,dis_rxdet_inp3_quirk;
snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+ status = "disabled";
};

sata: sata@3200000 {
--
2.7.4

2020-07-13 07:11:49

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: ls1043a: update USB nodes status to match board config

On Tue, Jul 07, 2020 at 03:40:31PM +0800, Ran Wang wrote:
> ls1043a-rdb and ls1043a-qds board’s default HW config (such as
> pin mux selection) would not enable some USB controllers’
> data path, which causing over-current detected on those
> controllers. This will hit the case of ‘xhci driver prevent bus suspend
> if a root hub port detected over-current condition’, causing system
> failed to be suspended. So disable them in device tree to resolve this
> issue.
>
> Signed-off-by: Ran Wang <[email protected]>

Applied, thanks.