2020-07-16 14:20:51

by B K Karthik

[permalink] [raw]
Subject: [PATCH v3] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

fixed sparse warnings by adding a cast in assignment from
void [noderef] __user * to unsigned int __force *
and a reverse cast in argument from
unsigned int * to unsigned int __user * .

Signed-off-by: B K Karthik <[email protected]>
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 3f70e5dfac39..9cdc1e8a022d 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2956,7 +2956,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd,
cmd->scan_end_arg = v32.scan_end_arg;
cmd->stop_src = v32.stop_src;
cmd->stop_arg = v32.stop_arg;
- cmd->chanlist = compat_ptr(v32.chanlist);
+ cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist);
cmd->chanlist_len = v32.chanlist_len;
cmd->data = compat_ptr(v32.data);
cmd->data_len = v32.data_len;
@@ -2983,7 +2983,7 @@ static int put_compat_cmd(struct comedi32_cmd_struct __user *cmd32,
v32.stop_src = cmd->stop_src;
v32.stop_arg = cmd->stop_arg;
/* Assume chanlist pointer is unchanged. */
- v32.chanlist = ptr_to_compat(cmd->chanlist);
+ v32.chanlist = ptr_to_compat((unsigned int __user *)cmd->chanlist);
v32.chanlist_len = cmd->chanlist_len;
v32.data = ptr_to_compat(cmd->data);
v32.data_len = cmd->data_len;
--
2.20.1


Attachments:
(No filename) (1.39 kB)
signature.asc (673.00 B)
Download all attachments

2020-07-16 14:27:05

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v3] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote:
> fixed sparse warnings by adding a cast in assignment from
> void [noderef] __user * to unsigned int __force *
> and a reverse cast in argument from
> unsigned int * to unsigned int __user * .
>
> Signed-off-by: B K Karthik <[email protected]>
> ---
> drivers/staging/comedi/comedi_fops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

What changed from previous versions?

That always goes below the --- line.

Please fix that up and resend a v4.

thanks,

greg k-h

2020-07-16 14:31:11

by B K Karthik

[permalink] [raw]
Subject: Re: [PATCH v3] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

On Thu, Jul 16, 2020 at 10:25 AM Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote:
> > fixed sparse warnings by adding a cast in assignment from
> > void [noderef] __user * to unsigned int __force *
> > and a reverse cast in argument from
> > unsigned int * to unsigned int __user * .
> >
> > Signed-off-by: B K Karthik <[email protected]>
> > ---
> > drivers/staging/comedi/comedi_fops.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> What changed from previous versions?

As Ian Abbott said "Minor quibble: the reverse cast is actually from
unsigned int * to"

Hence this is a change in the commit description.

>
> That always goes below the --- line.

I did not understand this sir, can you please clarify?

thanks,

karthik

2020-07-16 14:42:59

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v3] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings

On Thu, Jul 16, 2020 at 10:28:06AM -0400, B K Karthik wrote:
> On Thu, Jul 16, 2020 at 10:25 AM Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote:
> > > fixed sparse warnings by adding a cast in assignment from
> > > void [noderef] __user * to unsigned int __force *
> > > and a reverse cast in argument from
> > > unsigned int * to unsigned int __user * .
> > >
> > > Signed-off-by: B K Karthik <[email protected]>
> > > ---
> > > drivers/staging/comedi/comedi_fops.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > What changed from previous versions?
>
> As Ian Abbott said "Minor quibble: the reverse cast is actually from
> unsigned int * to"
>
> Hence this is a change in the commit description.

How was anyone supposed to know this? :)

> > That always goes below the --- line.
>
> I did not understand this sir, can you please clarify?

Please read the documentation for how to properly version patches, it's
in the submitting patches document. Do that and send a v4 for this.

thanks,

greg k-h