Hi all,
After merging the pinctrl tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: data definition has no type or storage class
783 | arch_initcall(mt6779_pinctrl_init);
| ^~~~~~~~~~~~~
drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int]
drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: parameter names (without types) in function declaration
drivers/pinctrl/mediatek/pinctrl-mt6779.c:779:19: warning: 'mt6779_pinctrl_init' defined but not used [-Wunused-function]
779 | static int __init mt6779_pinctrl_init(void)
| ^~~~~~~~~~~~~~~~~~~
Caused by commit
e6f744c6ad4f ("pinctrl: mediatek: add pinctrl support for MT6779 SoC")
Forgot to include module.h (since it is tristate in Kconfig) or init.h?
I used the pinctrl tree from next-20200716 for today.
--
Cheers,
Stephen Rothwell
On Fri, 2020-07-17 at 17:16 +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: data definition has no type or storage class
> 783 | arch_initcall(mt6779_pinctrl_init);
> | ^~~~~~~~~~~~~
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: error: type defaults to 'int' in declaration of 'arch_initcall' [-Werror=implicit-int]
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: parameter names (without types) in function declaration
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:779:19: warning: 'mt6779_pinctrl_init' defined but not used [-Wunused-function]
> 779 | static int __init mt6779_pinctrl_init(void)
> | ^~~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
> e6f744c6ad4f ("pinctrl: mediatek: add pinctrl support for MT6779 SoC")
>
> Forgot to include module.h (since it is tristate in Kconfig) or init.h?
>
> I used the pinctrl tree from next-20200716 for today.
>
My fault, I'll fix it in next version.
(Series: Add basic SoC Support for Mediatek MT6779 SoC)
Thank you for your message
Hanks Chen
On Fri, Jul 17, 2020 at 11:01 AM Hanks Chen <[email protected]> wrote:
> On Fri, 2020-07-17 at 17:16 +1000, Stephen Rothwell wrote:
> > Caused by commit
> >
> > e6f744c6ad4f ("pinctrl: mediatek: add pinctrl support for MT6779 SoC")
> >
> > Forgot to include module.h (since it is tristate in Kconfig) or init.h?
> >
> > I used the pinctrl tree from next-20200716 for today.
> >
>
> My fault, I'll fix it in next version.
> (Series: Add basic SoC Support for Mediatek MT6779 SoC)
OK I pulled out all the MTK6779 patches from my tree and wait
for a new version.
Yours,
Linus Walleij