2020-07-21 14:52:48

by Abanoub Sameh

Subject: [PATCH 2/2] gpio: gpio-pch.c: fixed coding style issue

Added a lined between a declaration and other statements according to the
kenel coding style.

Signed-off-by: Abanoub Sameh <[email protected]>
---
drivers/gpio/gpio-pch.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 71dde7ceb7af..039822978eaf 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -199,6 +199,7 @@ static void __maybe_unused pch_gpio_restore_reg_conf(struct pch_gpio *chip)
static int pch_gpio_to_irq(struct gpio_chip *gpio, unsigned int offset)
{
struct pch_gpio *chip = gpiochip_get_data(gpio);
+
return chip->irq_base + offset;
}

--
2.28.0.rc0

2020-07-21 16:10:37

by Andy Shevchenko

Subject: Re: [PATCH 2/2] gpio: gpio-pch.c: fixed coding style issue

On Tue, Jul 21, 2020 at 5:51 PM Abanoub Sameh <[email protected]> wrote:
>
> Added a lined between a declaration and other statements according to the
> kenel coding style.

Besides the typo in the word 'kernel' the subject is not okay.
I fixed this locally this time.

I also highly recommend to read https://chris.beams.io/posts/git-commit/.

--
With Best Regards,
Andy Shevchenko