Support sharing vdev buffer between multiple vdevs by using name
"vdevbuffer".
Reviewed-by: Richard Zhu <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
---
drivers/remoteproc/remoteproc_virtio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
index dfd3808c34fd..5d78ebea111e 100644
--- a/drivers/remoteproc/remoteproc_virtio.c
+++ b/drivers/remoteproc/remoteproc_virtio.c
@@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
/* Try to find dedicated vdev buffer carveout */
mem = rproc_find_carveout_by_name(rproc, "vdev%dbuffer", rvdev->index);
+ if (!mem)
+ mem = rproc_find_carveout_by_name(rproc, "vdevbuffer");
if (mem) {
phys_addr_t pa;
--
2.16.4
Hi Peng,
On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote:
> Support sharing vdev buffer between multiple vdevs by using name
> "vdevbuffer".
>
> Reviewed-by: Richard Zhu <[email protected]>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> drivers/remoteproc/remoteproc_virtio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
> index dfd3808c34fd..5d78ebea111e 100644
> --- a/drivers/remoteproc/remoteproc_virtio.c
> +++ b/drivers/remoteproc/remoteproc_virtio.c
> @@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
>
> /* Try to find dedicated vdev buffer carveout */
> mem = rproc_find_carveout_by_name(rproc, "vdev%dbuffer", rvdev->index);
> + if (!mem)
> + mem = rproc_find_carveout_by_name(rproc, "vdevbuffer");
We already have a way to share buffers [1], do you think it would work for you? I
would rather proceed that way to avoid introducing a 3rd way to deal with vdev
buffers.
Thanks,
Mathieu
[1]. https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/remoteproc/remoteproc_virtio.c#L389
> if (mem) {
> phys_addr_t pa;
>
> --
> 2.16.4
>
Hi Mathieu,
> Subject: Re: [PATCH] remoteproc: virtio: support sharing vdev buffer
>
> Hi Peng,
>
> On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote:
> > Support sharing vdev buffer between multiple vdevs by using name
> > "vdevbuffer".
> >
> > Reviewed-by: Richard Zhu <[email protected]>
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > drivers/remoteproc/remoteproc_virtio.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/remoteproc/remoteproc_virtio.c
> > b/drivers/remoteproc/remoteproc_virtio.c
> > index dfd3808c34fd..5d78ebea111e 100644
> > --- a/drivers/remoteproc/remoteproc_virtio.c
> > +++ b/drivers/remoteproc/remoteproc_virtio.c
> > @@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev,
> > int id)
> >
> > /* Try to find dedicated vdev buffer carveout */
> > mem = rproc_find_carveout_by_name(rproc, "vdev%dbuffer",
> > rvdev->index);
> > + if (!mem)
> > + mem = rproc_find_carveout_by_name(rproc, "vdevbuffer");
>
> We already have a way to share buffers [1], do you think it would work for you?
> I would rather proceed that way to avoid introducing a 3rd way to deal with
> vdev buffers.
That should work for me. I just need to move the vdevbuffer to the 1st one
inside the memory-region.
BTW: Do you have time to give a review for
https://patchwork.kernel.org/patch/11688751/
Thanks,
Peng.
>
> Thanks,
> Mathieu
>
> [1].
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
> ootlin.com%2Flinux%2Fv5.8-rc4%2Fsource%2Fdrivers%2Fremoteproc%2Frem
> oteproc_virtio.c%23L389&data=02%7C01%7Cpeng.fan%40nxp.com%7C
> 760ae238005c49fe20db08d833e193ca%7C686ea1d3bc2b4c6fa92cd99c5c30
> 1635%7C0%7C0%7C637316391223184319&sdata=UTN8YVaEynomrwFx
> 7aTCJ7fp0fjfIS8fscfGG67naKk%3D&reserved=0
>
> > if (mem) {
> > phys_addr_t pa;
> >
> > --
> > 2.16.4
> >
On Thu, 30 Jul 2020 at 00:22, Peng Fan <[email protected]> wrote:
>
> Hi Mathieu,
>
> > Subject: Re: [PATCH] remoteproc: virtio: support sharing vdev buffer
> >
> > Hi Peng,
> >
> > On Wed, Jul 22, 2020 at 09:15:43PM +0800, Peng Fan wrote:
> > > Support sharing vdev buffer between multiple vdevs by using name
> > > "vdevbuffer".
> > >
> > > Reviewed-by: Richard Zhu <[email protected]>
> > > Signed-off-by: Peng Fan <[email protected]>
> > > ---
> > > drivers/remoteproc/remoteproc_virtio.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/remoteproc/remoteproc_virtio.c
> > > b/drivers/remoteproc/remoteproc_virtio.c
> > > index dfd3808c34fd..5d78ebea111e 100644
> > > --- a/drivers/remoteproc/remoteproc_virtio.c
> > > +++ b/drivers/remoteproc/remoteproc_virtio.c
> > > @@ -343,6 +343,8 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev,
> > > int id)
> > >
> > > /* Try to find dedicated vdev buffer carveout */
> > > mem = rproc_find_carveout_by_name(rproc, "vdev%dbuffer",
> > > rvdev->index);
> > > + if (!mem)
> > > + mem = rproc_find_carveout_by_name(rproc, "vdevbuffer");
> >
> > We already have a way to share buffers [1], do you think it would work for you?
> > I would rather proceed that way to avoid introducing a 3rd way to deal with
> > vdev buffers.
>
> That should work for me. I just need to move the vdevbuffer to the 1st one
> inside the memory-region.
Perfect
>
> BTW: Do you have time to give a review for
> https://patchwork.kernel.org/patch/11688751/
>
Unfortunately not in a little while. There are a couple of beefy
patchset in the queue ahead of yours and to make matters worse I am
away next week.
> Thanks,
> Peng.
>
> >
> > Thanks,
> > Mathieu
> >
> > [1].
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
> > ootlin.com%2Flinux%2Fv5.8-rc4%2Fsource%2Fdrivers%2Fremoteproc%2Frem
> > oteproc_virtio.c%23L389&data=02%7C01%7Cpeng.fan%40nxp.com%7C
> > 760ae238005c49fe20db08d833e193ca%7C686ea1d3bc2b4c6fa92cd99c5c30
> > 1635%7C0%7C0%7C637316391223184319&sdata=UTN8YVaEynomrwFx
> > 7aTCJ7fp0fjfIS8fscfGG67naKk%3D&reserved=0
> >
> > > if (mem) {
> > > phys_addr_t pa;
> > >
> > > --
> > > 2.16.4
> > >