2020-08-17 01:33:06

by Xu Wang

Subject: [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk()

Using ata_link_info() instead of ata_link_printk().

Signed-off-by: Xu Wang <[email protected]>
---
drivers/ata/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 0c0a736eb861..9d72d907b4ee 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -807,7 +807,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
(sstatus & 0xf) != 1)
break;

- ata_link_printk(link, KERN_INFO, "avn bounce port%d\n",
+ ata_link_info(link, "avn bounce port%d\n",
port);

pci_read_config_word(pdev, 0x92, &val);
--
2.17.1

2020-08-17 03:11:37

by Jens Axboe

Subject: Re: [PATCH] ata: ahci: use ata_link_info() instead of ata_link_printk()

On 8/16/20 6:18 PM, Xu Wang wrote:
> Using ata_link_info() instead of ata_link_printk().
>
> Signed-off-by: Xu Wang <[email protected]>
> ---
> drivers/ata/ahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 0c0a736eb861..9d72d907b4ee 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -807,7 +807,7 @@ static int ahci_avn_hardreset(struct ata_link *link, unsigned int *class,
> (sstatus & 0xf) != 1)
> break;
>
> - ata_link_printk(link, KERN_INFO, "avn bounce port%d\n",
> + ata_link_info(link, "avn bounce port%d\n",
> port);

Why not collapse that into one line as well when making that change, as
it now fits just fine?

Apart from that, looks fine to me.

--
Jens Axboe