USB external connector chip PTN5150 used on the Intel LGM SoC
boards to detect the USB type and connection.
---
v1:
- Initial version
Ramuthevar Vadivel Murugan (9):
extcon: extcon-ptn5150: Switch to GENMASK() for vendor and device ID's
extcon: extcon-ptn5150: Switch to GENMASK() for VBUS detection macro
extcon: extcon-ptn5150: Switch to BIT() macro for cable attach
extcon: extcon-ptn5150: Switch to BIT() for cable detach macro
extcon: extcon-ptn5150: Switch to GENMASK() for port attachment macro
extcon: extcon-ptn5150: Set and get the VBUS and POLARITY property
state
extcon: extcon-ptn5150: Add USB debug accessory support
extcon: extcon-ptn5150: Add USB analog audio accessory support
extcon: extcon-ptn5150: Remove unused variable and extra space
drivers/extcon/extcon-ptn5150.c | 135 ++++++++++++++++++++++++----------------
1 file changed, 82 insertions(+), 53 deletions(-)
--
2.11.0
From: Ramuthevar Vadivel Murugan <[email protected]>
Set and get the VBUS and POLARITY property state.
Signed-off-by: Ramuthevar Vadivel Murugan <[email protected]>
---
drivers/extcon/extcon-ptn5150.c | 75 ++++++++++++++++++++++++++++++-----------
1 file changed, 55 insertions(+), 20 deletions(-)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index 31b7cbf1551d..5612dc0ef2af 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -64,6 +64,12 @@ static const unsigned int ptn5150_extcon_cable[] = {
EXTCON_NONE,
};
+enum {
+ POLARITY_NC,
+ POLARITY_CC1,
+ POLARITY_CC2,
+};
+
static const struct regmap_config ptn5150_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
@@ -74,9 +80,14 @@ static void ptn5150_irq_work(struct work_struct *work)
{
struct ptn5150_info *info = container_of(work,
struct ptn5150_info, irq_work);
- int ret = 0;
+ int ret = 0, x = 0;
unsigned int reg_data;
unsigned int int_status;
+ union extcon_property_value vbus_detected;
+ union extcon_property_value flipped;
+ bool host_vbus = false;
+ bool host = false;
+ bool dev = false;
if (!info->edev)
return;
@@ -90,6 +101,11 @@ static void ptn5150_irq_work(struct work_struct *work)
return;
}
+ dev_dbg(info->dev, "CC POLARITY status:%x\n", reg_data);
+ x = FIELD_GET(PTN5150_REG_INT_CABLE_ATTACH_MASK, reg_data);
+ flipped.intval = (x == POLARITY_CC2);
+ vbus_detected.intval = !!(reg_data & PTN5150_REG_CC_VBUS_DETECTION);
+
/* Clear interrupt. Read would clear the register */
ret = regmap_read(info->regmap, PTN5150_REG_INT_STATUS, &int_status);
if (ret) {
@@ -111,6 +127,7 @@ static void ptn5150_irq_work(struct work_struct *work)
switch (port_status) {
case PTN5150_DFP_ATTACHED:
+ dev = true;
extcon_set_state_sync(info->edev,
EXTCON_USB_HOST, false);
gpiod_set_value(info->vbus_gpiod, 0);
@@ -118,6 +135,8 @@ static void ptn5150_irq_work(struct work_struct *work)
true);
break;
case PTN5150_UFP_ATTACHED:
+ host_vbus = !vbus_detected.intval;
+ host = true;
extcon_set_state_sync(info->edev, EXTCON_USB,
false);
vbus = FIELD_GET(PTN5150_REG_CC_VBUS_DETECTION,
@@ -127,6 +146,9 @@ static void ptn5150_irq_work(struct work_struct *work)
else
gpiod_set_value(info->vbus_gpiod, 1);
+ extcon_set_property(info->edev, EXTCON_USB_HOST,
+ EXTCON_PROP_USB_TYPEC_POLARITY,
+ flipped);
extcon_set_state_sync(info->edev,
EXTCON_USB_HOST, true);
break;
@@ -145,6 +167,8 @@ static void ptn5150_irq_work(struct work_struct *work)
}
}
+ if (host_vbus)
+ gpiod_set_value(info->vbus_gpiod, host_vbus);
/* Clear interrupt. Read would clear the register */
ret = regmap_read(info->regmap, PTN5150_REG_INT_REG_STATUS,
&int_status);
@@ -155,6 +179,11 @@ static void ptn5150_irq_work(struct work_struct *work)
return;
}
+ extcon_set_property(info->edev, host ? EXTCON_USB_HOST : EXTCON_USB,
+ EXTCON_PROP_USB_VBUS, vbus_detected);
+ extcon_set_state_sync(info->edev, EXTCON_USB_HOST, host);
+ extcon_set_state_sync(info->edev, EXTCON_USB, dev);
+
mutex_unlock(&info->mutex);
}
@@ -227,7 +256,7 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
dev_err(dev, "failed to get INT GPIO\n");
return PTR_ERR(info->int_gpiod);
}
- info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);
+ info->vbus_gpiod = devm_gpiod_get_optional(&i2c->dev, "vbus", GPIOD_IN);
if (IS_ERR(info->vbus_gpiod)) {
dev_err(dev, "failed to get VBUS GPIO\n");
return PTR_ERR(info->vbus_gpiod);
@@ -250,24 +279,6 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
return ret;
}
- if (info->int_gpiod) {
- info->irq = gpiod_to_irq(info->int_gpiod);
- if (info->irq < 0) {
- dev_err(dev, "failed to get INTB IRQ\n");
- return info->irq;
- }
-
- ret = devm_request_threaded_irq(dev, info->irq, NULL,
- ptn5150_irq_handler,
- IRQF_TRIGGER_FALLING |
- IRQF_ONESHOT,
- i2c->name, info);
- if (ret < 0) {
- dev_err(dev, "failed to request handler for INTB IRQ\n");
- return ret;
- }
- }
-
/* Allocate extcon device */
info->edev = devm_extcon_dev_allocate(info->dev, ptn5150_extcon_cable);
if (IS_ERR(info->edev)) {
@@ -282,6 +293,30 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
return ret;
}
+ extcon_set_property_capability(info->edev, EXTCON_USB,
+ EXTCON_PROP_USB_VBUS);
+ extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
+ EXTCON_PROP_USB_VBUS);
+ extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
+ EXTCON_PROP_USB_TYPEC_POLARITY);
+
+ info->irq = gpiod_to_irq(info->int_gpiod);
+ if (info->irq < 0) {
+ dev_err(dev, "failed to get INTB IRQ\n");
+ return info->irq;
+ }
+
+ ret = devm_request_threaded_irq(dev, info->irq, NULL, ptn5150_irq_handler,
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ i2c->name, info);
+ if (ret < 0) {
+ dev_err(dev, "failed to request handler for INTB IRQ\n");
+ return ret;
+ }
+
+ /* PNT5150 interrupt is level based, read result once in case we */
+ schedule_work(&info->irq_work);
+
/* Initialize PTN5150 device and print vendor id and version id */
ret = ptn5150_init_dev_type(info);
if (ret)
--
2.11.0
From: Ramuthevar Vadivel Murugan <[email protected]>
Add USB analog audio accessory attached and detection support.
Signed-off-by: Ramuthevar Vadivel Murugan <[email protected]>
---
drivers/extcon/extcon-ptn5150.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index b985a5e5c9bc..140994ac43ed 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -34,6 +34,7 @@ enum ptn5150_reg {
#define PTN5150_DFP_ATTACHED 0x1
#define PTN5150_UFP_ATTACHED 0x2
#define PTN5150_DEBUG_ATTACHED 0x3
+#define PTN5150_AUDIO_ATTACHED 0x4
/* Define PTN5150 MASK/SHIFT constant */
#define PTN5150_REG_DEVICE_ID_VERSION GENMASK(7, 3)
@@ -63,6 +64,7 @@ static const unsigned int ptn5150_extcon_cable[] = {
EXTCON_USB,
EXTCON_USB_HOST,
EXTCON_JIG,
+ EXTCON_JACK_HEADPHONE,
EXTCON_NONE,
};
@@ -89,6 +91,7 @@ static void ptn5150_irq_work(struct work_struct *work)
union extcon_property_value flipped;
bool host_vbus = false;
bool debug = false;
+ bool audio = false;
bool host = false;
bool dev = false;
@@ -158,6 +161,9 @@ static void ptn5150_irq_work(struct work_struct *work)
case PTN5150_DEBUG_ATTACHED:
debug = true;
break;
+ case PTN5150_AUDIO_ATTACHED:
+ audio = true;
+ break;
default:
dev_err(info->dev,
"Unknown Port status : %x\n",
@@ -189,6 +195,7 @@ static void ptn5150_irq_work(struct work_struct *work)
EXTCON_PROP_USB_VBUS, vbus_detected);
extcon_set_state_sync(info->edev, EXTCON_USB_HOST, host);
extcon_set_state_sync(info->edev, EXTCON_JIG, debug);
+ extcon_set_state_sync(info->edev, EXTCON_JACK_HEADPHONE, audio);
extcon_set_state_sync(info->edev, EXTCON_USB, dev);
mutex_unlock(&info->mutex);
--
2.11.0
From: Ramuthevar Vadivel Murugan <[email protected]>
Add USB debug accessory support.
Signed-off-by: Ramuthevar Vadivel Murugan <[email protected]>
---
drivers/extcon/extcon-ptn5150.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index 5612dc0ef2af..b985a5e5c9bc 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -33,6 +33,7 @@ enum ptn5150_reg {
#define PTN5150_DFP_ATTACHED 0x1
#define PTN5150_UFP_ATTACHED 0x2
+#define PTN5150_DEBUG_ATTACHED 0x3
/* Define PTN5150 MASK/SHIFT constant */
#define PTN5150_REG_DEVICE_ID_VERSION GENMASK(7, 3)
@@ -61,6 +62,7 @@ struct ptn5150_info {
static const unsigned int ptn5150_extcon_cable[] = {
EXTCON_USB,
EXTCON_USB_HOST,
+ EXTCON_JIG,
EXTCON_NONE,
};
@@ -86,6 +88,7 @@ static void ptn5150_irq_work(struct work_struct *work)
union extcon_property_value vbus_detected;
union extcon_property_value flipped;
bool host_vbus = false;
+ bool debug = false;
bool host = false;
bool dev = false;
@@ -152,6 +155,9 @@ static void ptn5150_irq_work(struct work_struct *work)
extcon_set_state_sync(info->edev,
EXTCON_USB_HOST, true);
break;
+ case PTN5150_DEBUG_ATTACHED:
+ debug = true;
+ break;
default:
dev_err(info->dev,
"Unknown Port status : %x\n",
@@ -182,6 +188,7 @@ static void ptn5150_irq_work(struct work_struct *work)
extcon_set_property(info->edev, host ? EXTCON_USB_HOST : EXTCON_USB,
EXTCON_PROP_USB_VBUS, vbus_detected);
extcon_set_state_sync(info->edev, EXTCON_USB_HOST, host);
+ extcon_set_state_sync(info->edev, EXTCON_JIG, debug);
extcon_set_state_sync(info->edev, EXTCON_USB, dev);
mutex_unlock(&info->mutex);
--
2.11.0
From: Ramuthevar Vadivel Murugan <[email protected]>
Remove the unused variable and extra space.
Signed-off-by: Ramuthevar Vadivel Murugan <[email protected]>
---
drivers/extcon/extcon-ptn5150.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index 140994ac43ed..a7544ab058c0 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -50,7 +50,6 @@ enum ptn5150_reg {
struct ptn5150_info {
struct device *dev;
struct extcon_dev *edev;
- struct i2c_client *i2c;
struct regmap *regmap;
struct gpio_desc *int_gpiod;
struct gpio_desc *vbus_gpiod;
@@ -201,7 +200,6 @@ static void ptn5150_irq_work(struct work_struct *work)
mutex_unlock(&info->mutex);
}
-
static irqreturn_t ptn5150_irq_handler(int irq, void *data)
{
struct ptn5150_info *info = data;
@@ -264,7 +262,6 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
i2c_set_clientdata(i2c, info);
info->dev = &i2c->dev;
- info->i2c = i2c;
info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
if (IS_ERR(info->int_gpiod)) {
dev_err(dev, "failed to get INT GPIO\n");
--
2.11.0
On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> USB external connector chip PTN5150 used on the Intel LGM SoC
> boards to detect the USB type and connection.
Internally I meant you can send cleanups, but couple of patches here are the
features and were still under discussion... But here we are.
> ---
> v1:
> - Initial version
>
> Ramuthevar Vadivel Murugan (9):
> extcon: extcon-ptn5150: Switch to GENMASK() for vendor and device ID's
> extcon: extcon-ptn5150: Switch to GENMASK() for VBUS detection macro
> extcon: extcon-ptn5150: Switch to BIT() macro for cable attach
> extcon: extcon-ptn5150: Switch to BIT() for cable detach macro
> extcon: extcon-ptn5150: Switch to GENMASK() for port attachment macro
> extcon: extcon-ptn5150: Set and get the VBUS and POLARITY property
> state
> extcon: extcon-ptn5150: Add USB debug accessory support
> extcon: extcon-ptn5150: Add USB analog audio accessory support
> extcon: extcon-ptn5150: Remove unused variable and extra space
>
> drivers/extcon/extcon-ptn5150.c | 135 ++++++++++++++++++++++++----------------
> 1 file changed, 82 insertions(+), 53 deletions(-)
>
> --
> 2.11.0
>
--
With Best Regards,
Andy Shevchenko
Hi Andy,
On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
> On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> USB external connector chip PTN5150 used on the Intel LGM SoC
>> boards to detect the USB type and connection.
> Internally I meant you can send cleanups, but couple of patches here are the
> features and were still under discussion... But here we are.
you mean asking us to implement the Heikki suggested as below..
Heikki Krogerus: register the port and the partner attached to it with
the USB Type-C connector class in the driver. Is my understaanding
right? if not, please explain it. Thanks!
Regards
Vadivel
>
On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
<[email protected]> wrote:
> On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
> > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> >> USB external connector chip PTN5150 used on the Intel LGM SoC
> >> boards to detect the USB type and connection.
> > Internally I meant you can send cleanups, but couple of patches here are the
> > features and were still under discussion... But here we are.
>
> you mean asking us to implement the Heikki suggested as below..
>
> Heikki Krogerus: register the port and the partner attached to it with
> the USB Type-C connector class in the driver. Is my understaanding
> right? if not, please explain it. Thanks!
When you mention somebody, don't forget to Cc them (now done by me).
--
With Best Regards,
Andy Shevchenko
Hi Andy,
On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
> On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
> <[email protected]> wrote:
>> On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
>>> On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>>>> USB external connector chip PTN5150 used on the Intel LGM SoC
>>>> boards to detect the USB type and connection.
>>> Internally I meant you can send cleanups, but couple of patches here are the
>>> features and were still under discussion... But here we are.
>>
>> you mean asking us to implement the Heikki suggested as below..
>>
>> Heikki Krogerus: register the port and the partner attached to it with
>> the USB Type-C connector class in the driver. Is my understaanding
>> right? if not, please explain it. Thanks!
>
> When you mention somebody, don't forget to Cc them (now done by me).
Sure, Thank you
Regards
Vadivel
>
On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> Hi Andy,
>
> On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
> > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
> > <[email protected]> wrote:
> > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
> > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > > > USB external connector chip PTN5150 used on the Intel LGM SoC
> > > > > boards to detect the USB type and connection.
> > > > Internally I meant you can send cleanups, but couple of patches here are the
> > > > features and were still under discussion... But here we are.
> > >
> > > you mean asking us to implement the Heikki suggested as below..
> > >
> > > Heikki Krogerus: register the port and the partner attached to it with
> > > the USB Type-C connector class in the driver. Is my understaanding
> > > right? if not, please explain it. Thanks!
> >
> > When you mention somebody, don't forget to Cc them (now done by me).
> Sure, Thank you
So the patches 1-5 are fine. The rest needs to be rewritten.
thanks,
--
heikki
Hi Heikki,
Thank you very much for the review comment...
On 25/8/2020 4:19 pm, Heikki Krogerus wrote:
> On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote:
>> Hi Andy,
>>
>> On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
>>> On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
>>> <[email protected]> wrote:
>>>> On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
>>>>> On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>>>>>> USB external connector chip PTN5150 used on the Intel LGM SoC
>>>>>> boards to detect the USB type and connection.
>>>>> Internally I meant you can send cleanups, but couple of patches here are the
>>>>> features and were still under discussion... But here we are.
>>>>
>>>> you mean asking us to implement the Heikki suggested as below..
>>>>
>>>> Heikki Krogerus: register the port and the partner attached to it with
>>>> the USB Type-C connector class in the driver. Is my understaanding
>>>> right? if not, please explain it. Thanks!
>>>
>>> When you mention somebody, don't forget to Cc them (now done by me).
>> Sure, Thank you
>
> So the patches 1-5 are fine. The rest needs to be rewritten.
Already Krzysztof submitted all the patches and got approved, so we
started sending only one patch which support to Intel LGM SoC based
boards, Thanks!
Regards
Vadivel
>
> thanks,
>
On Wed, Aug 26, 2020 at 10:51:37AM +0800, Ramuthevar, Vadivel MuruganX wrote:
> On 25/8/2020 4:19 pm, Heikki Krogerus wrote:
> > On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> > > On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
> > > > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
> > > > <[email protected]> wrote:
> > > > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
> > > > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > > > > > USB external connector chip PTN5150 used on the Intel LGM SoC
> > > > > > > boards to detect the USB type and connection.
> > > > > > Internally I meant you can send cleanups, but couple of patches here are the
> > > > > > features and were still under discussion... But here we are.
> > > > >
> > > > > you mean asking us to implement the Heikki suggested as below..
> > > > >
> > > > > Heikki Krogerus: register the port and the partner attached to it with
> > > > > the USB Type-C connector class in the driver. Is my understaanding
> > > > > right? if not, please explain it. Thanks!
> > > >
> > > > When you mention somebody, don't forget to Cc them (now done by me).
> > > Sure, Thank you
> >
> > So the patches 1-5 are fine. The rest needs to be rewritten.
> Already Krzysztof submitted all the patches and got approved, so we started
> sending only one patch which support to Intel LGM SoC based boards, Thanks!
I'm not sure what you meant by above.
Krzysztof suggested you to squash all first patches into 1 (or two) and he
approves it. What you have to do is follow his advise and send v2 where it will
be one (or two) patch with his tag attached.
Krzysztof, is it correct what I'm saying?
--
With Best Regards,
Andy Shevchenko
Hi Andy,
On 26/8/2020 5:18 pm, Andy Shevchenko wrote:
> On Wed, Aug 26, 2020 at 10:51:37AM +0800, Ramuthevar, Vadivel MuruganX wrote:
>> On 25/8/2020 4:19 pm, Heikki Krogerus wrote:
>>> On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote:
>>>> On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
>>>>> On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
>>>>> <[email protected]> wrote:
>>>>>> On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
>>>>>>> On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>>>>>>>> USB external connector chip PTN5150 used on the Intel LGM SoC
>>>>>>>> boards to detect the USB type and connection.
>>>>>>> Internally I meant you can send cleanups, but couple of patches here are the
>>>>>>> features and were still under discussion... But here we are.
>>>>>>
>>>>>> you mean asking us to implement the Heikki suggested as below..
>>>>>>
>>>>>> Heikki Krogerus: register the port and the partner attached to it with
>>>>>> the USB Type-C connector class in the driver. Is my understaanding
>>>>>> right? if not, please explain it. Thanks!
>>>>>
>>>>> When you mention somebody, don't forget to Cc them (now done by me).
>>>> Sure, Thank you
>>>
>>> So the patches 1-5 are fine. The rest needs to be rewritten.
>> Already Krzysztof submitted all the patches and got approved, so we started
>> sending only one patch which support to Intel LGM SoC based boards, Thanks!
>
> I'm not sure what you meant by above.
>
> Krzysztof suggested you to squash all first patches into 1 (or two) and he
> approves it. What you have to do is follow his advise and send v2 where it will
> be one (or two) patch with his tag attached.
Yes, you're right, the above discussion was before Krzysztof reviewed my
patches, sure will follow his advise, thanks!
Regards
Vadivel
>
> Krzysztof, is it correct what I'm saying?
>
On Wed, Aug 26, 2020 at 12:18:04PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 26, 2020 at 10:51:37AM +0800, Ramuthevar, Vadivel MuruganX wrote:
> > On 25/8/2020 4:19 pm, Heikki Krogerus wrote:
> > > On Wed, Aug 19, 2020 at 04:45:38PM +0800, Ramuthevar, Vadivel MuruganX wrote:
> > > > On 19/8/2020 3:55 pm, Andy Shevchenko wrote:
> > > > > On Wed, Aug 19, 2020 at 8:38 AM Ramuthevar, Vadivel MuruganX
> > > > > <[email protected]> wrote:
> > > > > > On 18/8/2020 4:40 pm, Andy Shevchenko wrote:
> > > > > > > On Tue, Aug 18, 2020 at 02:57:18PM +0800, Ramuthevar,Vadivel MuruganX wrote:
> > > > > > > > USB external connector chip PTN5150 used on the Intel LGM SoC
> > > > > > > > boards to detect the USB type and connection.
> > > > > > > Internally I meant you can send cleanups, but couple of patches here are the
> > > > > > > features and were still under discussion... But here we are.
> > > > > >
> > > > > > you mean asking us to implement the Heikki suggested as below..
> > > > > >
> > > > > > Heikki Krogerus: register the port and the partner attached to it with
> > > > > > the USB Type-C connector class in the driver. Is my understaanding
> > > > > > right? if not, please explain it. Thanks!
> > > > >
> > > > > When you mention somebody, don't forget to Cc them (now done by me).
> > > > Sure, Thank you
> > >
> > > So the patches 1-5 are fine. The rest needs to be rewritten.
> > Already Krzysztof submitted all the patches and got approved, so we started
> > sending only one patch which support to Intel LGM SoC based boards, Thanks!
>
> I'm not sure what you meant by above.
>
> Krzysztof suggested you to squash all first patches into 1 (or two) and he
> approves it. What you have to do is follow his advise and send v2 where it will
> be one (or two) patch with his tag attached.
>
> Krzysztof, is it correct what I'm saying?
Yes, correct. I guess Vadivel mentioned my patchset which was sent some
days before and recently got applied into extcon tree.
I think there is no misunderstanding here.
Best regards,
Krzysztof