2020-08-19 22:22:23

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: PCI: intel,lgm-pcie: Fix matching on all snps,dw-pcie instances

The intel,lgm-pcie binding is matching on all snps,dw-pcie instances
which is wrong. Add a custom 'select' entry to fix this.

Fixes: e54ea45a4955 ("dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller")
Cc: Bjorn Helgaas <[email protected]>
Cc: Dilip Kota <[email protected]>
Cc: [email protected]
Signed-off-by: Rob Herring <[email protected]>
---
I'll take this via the DT tree.

Rob

Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
index 64b2c64ca806..a1e2be737eec 100644
--- a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
@@ -9,6 +9,14 @@ title: PCIe RC controller on Intel Gateway SoCs
maintainers:
- Dilip Kota <[email protected]>

+select:
+ properties:
+ compatible:
+ contains:
+ const: intel,lgm-pcie
+ required:
+ - compatible
+
properties:
compatible:
items:
--
2.25.1

2020-08-20 07:31:36

by Dilip Kota

Subject: Re: [PATCH] dt-bindings: PCI: intel,lgm-pcie: Fix matching on all snps,dw-pcie instances

On 8/20/2020 6:20 AM, Rob Herring wrote:
> The intel,lgm-pcie binding is matching on all snps,dw-pcie instances
> which is wrong. Add a custom 'select' entry to fix this.
>
> Fixes: e54ea45a4955 ("dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller")
> Cc: Bjorn Helgaas <[email protected]>
> Cc: Dilip Kota <[email protected]>
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>
> ---
> I'll take this via the DT tree.
>
> Rob
>
> Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> index 64b2c64ca806..a1e2be737eec 100644
> --- a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> @@ -9,6 +9,14 @@ title: PCIe RC controller on Intel Gateway SoCs
> maintainers:
> - Dilip Kota <[email protected]>
>
> +select:
> + properties:
> + compatible:
> + contains:
> + const: intel,lgm-pcie
> + required:
> + - compatible
> +
> properties:
> compatible:
> items:

Reviewed-by: Dilip Kota <[email protected]>

Regards,
Dilip