2020-08-21 13:02:27

by Niklas Cassel

Subject: [PATCH] scsi: scsi_debug: Remove superfluous close zone in resp_open_zone()

resp_open_zone() always calls zbc_open_zone() with parameter explicit
set to true.

If zbc_open_zone() is called with parameter explicit set to true, and
the current zone state is implicit open, it will call zbc_close_zone()
on the zone before proceeding.

Therefore, there is no need for resp_open_zone() to call zbc_close_zone()
on an implicitly open zone before calling zbc_open_zone().

Remove superfluous close zone in resp_open_zone().

Signed-off-by: Niklas Cassel <[email protected]>
---
drivers/scsi/scsi_debug.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 064ed680c0530..912d6f4878bae 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -4482,8 +4482,6 @@ static int resp_open_zone(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
goto fini;
}

- if (zc == ZC2_IMPLICIT_OPEN)
- zbc_close_zone(devip, zsp);
zbc_open_zone(devip, zsp, true);
fini:
write_unlock(macc_lckp);
--
2.26.2

2020-08-24 00:05:44

by Damien Le Moal

Subject: Re: [PATCH] scsi: scsi_debug: Remove superfluous close zone in resp_open_zone()

On 2020/08/21 22:00, Niklas Cassel wrote:
> resp_open_zone() always calls zbc_open_zone() with parameter explicit
> set to true.
>
> If zbc_open_zone() is called with parameter explicit set to true, and
> the current zone state is implicit open, it will call zbc_close_zone()
> on the zone before proceeding.
>
> Therefore, there is no need for resp_open_zone() to call zbc_close_zone()
> on an implicitly open zone before calling zbc_open_zone().
>
> Remove superfluous close zone in resp_open_zone().
>
> Signed-off-by: Niklas Cassel <[email protected]>
> ---
> drivers/scsi/scsi_debug.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 064ed680c0530..912d6f4878bae 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -4482,8 +4482,6 @@ static int resp_open_zone(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
> goto fini;
> }
>
> - if (zc == ZC2_IMPLICIT_OPEN)
> - zbc_close_zone(devip, zsp);
> zbc_open_zone(devip, zsp, true);
> fini:
> write_unlock(macc_lckp);
>

Looks good.

Reviewed-by: Damien Le Moal <[email protected]>

--
Damien Le Moal
Western Digital Research