2020-08-23 09:06:19

by Dinghao Liu

Subject: [PATCH] net: arc_emac: Fix memleak in arc_mdio_probe

When devm_gpiod_get_optional() fails, bus should be
freed just like when of_mdiobus_register() fails.

Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver")
Signed-off-by: Dinghao Liu <[email protected]>
---
drivers/net/ethernet/arc/emac_mdio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/arc/emac_mdio.c b/drivers/net/ethernet/arc/emac_mdio.c
index 0187dbf3b87d..54cdafdd067d 100644
--- a/drivers/net/ethernet/arc/emac_mdio.c
+++ b/drivers/net/ethernet/arc/emac_mdio.c
@@ -153,6 +153,7 @@ int arc_mdio_probe(struct arc_emac_priv *priv)
if (IS_ERR(data->reset_gpio)) {
error = PTR_ERR(data->reset_gpio);
dev_err(priv->dev, "Failed to request gpio: %d\n", error);
+ mdiobus_free(bus);
return error;
}

--
2.17.1

2020-08-23 14:54:26

by Andrew Lunn

Subject: Re: [PATCH] net: arc_emac: Fix memleak in arc_mdio_probe

On Sun, Aug 23, 2020 at 04:56:47PM +0800, Dinghao Liu wrote:
> When devm_gpiod_get_optional() fails, bus should be
> freed just like when of_mdiobus_register() fails.
>
> Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver")
> Signed-off-by: Dinghao Liu <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2020-08-25 01:03:10

by David Miller

Subject: Re: [PATCH] net: arc_emac: Fix memleak in arc_mdio_probe

From: Dinghao Liu <[email protected]>
Date: Sun, 23 Aug 2020 16:56:47 +0800

> When devm_gpiod_get_optional() fails, bus should be
> freed just like when of_mdiobus_register() fails.
>
> Fixes: 1bddd96cba03d ("net: arc_emac: support the phy reset for emac driver")
> Signed-off-by: Dinghao Liu <[email protected]>

Applied, thank you.