2020-08-26 06:50:15

by Peng Fan

Subject: [PATCH] clk: imx: fix composite peripheral flags

From: Peng Fan <[email protected]>

According to RM, for peripheral clock slice,
"IP clock slices must be stopped to change the clock source.".

So we must have CLK_SET_PARENT_GATE flag to avoid glitch.

Signed-off-by: Peng Fan <[email protected]>
---
drivers/clk/imx/clk-composite-8m.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c
index 78fb7e52a42a..2c309e3dc8e3 100644
--- a/drivers/clk/imx/clk-composite-8m.c
+++ b/drivers/clk/imx/clk-composite-8m.c
@@ -216,6 +216,7 @@ struct clk_hw *imx8m_clk_hw_composite_flags(const char *name,
div->width = PCG_PREDIV_WIDTH;
divider_ops = &imx8m_clk_composite_divider_ops;
mux_ops = &clk_mux_ops;
+ flags |= CLK_SET_PARENT_GATE;
}

div->lock = &imx_ccm_lock;
--
2.28.0

2020-09-05 01:36:52

by Shawn Guo

Subject: Re: [PATCH] clk: imx: fix composite peripheral flags

On Wed, Aug 26, 2020 at 03:14:07PM +0800, [email protected] wrote:
> From: Peng Fan <[email protected]>
>
> According to RM, for peripheral clock slice,
> "IP clock slices must be stopped to change the clock source.".
>
> So we must have CLK_SET_PARENT_GATE flag to avoid glitch.
>
> Signed-off-by: Peng Fan <[email protected]>

Applied, thanks.