From: Cameron Nemo <[email protected]>
RK3328 SoCs have one USB 3.0 OTG controller which uses DWC_USB3
core's general architecture. It can act as static xHCI host
controller, static device controller, USB 3.0/2.0 OTG basing
on ID of USB3.0 PHY.
Signed-off-by: William Wu <[email protected]>
Signed-off-by: Heiko Stuebner <[email protected]>
Signed-off-by: Cameron Nemo <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index bbdb19a3e85d..27e86bf06d3e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -983,6 +983,33 @@ usb_host0_ohci: usb@ff5d0000 {
status = "disabled";
};
+ usbdrd3: usb@ff600000 {
+ compatible = "rockchip,rk3328-dwc3";
+ clocks = <&cru SCLK_USB3OTG_REF>, <&cru SCLK_USB3OTG_SUSPEND>,
+ <&cru ACLK_USB3OTG>;
+ clock-names = "ref_clk", "suspend_clk",
+ "bus_clk";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+ status = "disabled";
+
+ usbdrd_dwc3: dwc3@ff600000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0xff600000 0x0 0x100000>;
+ interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
+ dr_mode = "otg";
+ phy_type = "utmi_wide";
+ snps,dis_enblslpm_quirk;
+ snps,dis-u2-freeclk-exists-quirk;
+ snps,dis_u2_susphy_quirk;
+ snps,dis_u3_susphy_quirk;
+ snps,dis-del-phy-power-chg-quirk;
+ snps,dis-tx-ipgap-linecheck-quirk;
+ status = "disabled";
+ };
+ };
+
gic: interrupt-controller@ff811000 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;
--
2.28.0
From: Cameron Nemo <[email protected]>
Enable USB3 nodes for the rk3328-based PINE Rock64 board.
Signed-off-by: Heiko Stuebner <[email protected]>
Signed-off-by: Cameron Nemo <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 86cfb5c50a94..82c27eab6a52 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -363,10 +363,6 @@ &tsadc {
status = "okay";
};
-&uart2 {
- status = "okay";
-};
-
&u2phy {
status = "okay";
@@ -379,11 +375,24 @@ u2phy_otg: otg-port {
};
};
+&uart2 {
+ status = "okay";
+};
+
&usb20_otg {
dr_mode = "host";
status = "okay";
};
+&usbdrd3 {
+ status = "okay";
+};
+
+&usbdrd_dwc3 {
+ dr_mode = "host";
+ status = "okay";
+};
+
&usb_host0_ehci {
status = "okay";
};
--
2.28.0
Hi Cameron,
Increase the version number for each new patch serie.
git format-patch -v4 -4 HEAD
In a previous comment I gave a sort example.
However, this patch serie is about usb3, so only touch the things
related to usb3 and leave the &uart2 node (legacy ;) ) untouched.
Improve the way in which your patches are send.
Your previous serie was incomplete.
Submit all patches with the same news server (Gmail for example) that
can handle plain text, because else you get 2 different Message-Ids:
<[email protected]>
<[email protected]>
git send-email --suppress-cc all --annotate --to <..> --cc <..> <patch1
patch2>
Not sure how robh filters patches, but your serie 'must' show up in the
link below or else wait for an eternity to get a ack-by.
https://patchwork.ozlabs.org/project/devicetree-bindings/list/
On 8/26/20 7:12 PM, [email protected] wrote:
> From: Cameron Nemo <[email protected]>
>
> Enable USB3 nodes for the rk3328-based PINE Rock64 board.
>
> Signed-off-by: Heiko Stuebner <[email protected]>
> Signed-off-by: Cameron Nemo <[email protected]>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 86cfb5c50a94..82c27eab6a52 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -363,10 +363,6 @@ &tsadc {
> status = "okay";
> };
>
> -&uart2 {
> - status = "okay";
> -};
> -
> &u2phy {
> status = "okay";
>
> @@ -379,11 +375,24 @@ u2phy_otg: otg-port {
> };
> };
>
> +&uart2 {
> + status = "okay";
> +};
> +
Don't touch/change.
> &usb20_otg {
> dr_mode = "host";
> status = "okay";
> };
>
> +&usbdrd3 {
> + status = "okay";
> +};
> +
> +&usbdrd_dwc3 {
> + dr_mode = "host";
> + status = "okay";
> +};
> +
> &usb_host0_ehci {
> status = "okay";
> };
>