2020-09-04 09:17:06

by Bean Huo

Subject: [PATCH 0/2] use generic_file_buffered_read()

From: Bean Huo <[email protected]>


Bean Huo (2):
block: use generic_file_buffered_read()
fs: isofs: use generic_file_buffered_read()

drivers/block/sunvdc.c | 6 +++---
fs/isofs/compress.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)

--
2.17.1

2020-09-04 09:19:14

by Bean Huo

Subject: [PATCH 2/2] fs: isofs: use generic_file_buffered_read()

From: Bean Huo <[email protected]>

do_generic_file_read() has been renamed to generic_file_buffered_read()
since commit 47c27bc46946 ("fs: pass iocb to do_generic_file_read").

Signed-off-by: Bean Huo <[email protected]>
---
fs/isofs/compress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c
index bc12ac7e2312..7541581c1064 100644
--- a/fs/isofs/compress.c
+++ b/fs/isofs/compress.c
@@ -312,7 +312,7 @@ static int zisofs_readpage(struct file *file, struct page *page)
end_index = (inode->i_size + PAGE_SIZE - 1) >> PAGE_SHIFT;
/*
* If this page is wholly outside i_size we just return zero;
- * do_generic_file_read() will handle this for us
+ * generic_file_buffered_read() will handle this for us
*/
if (index >= end_index) {
SetPageUptodate(page);
--
2.17.1

2020-09-04 16:56:46

by Jens Axboe

Subject: Re: [PATCH 0/2] use generic_file_buffered_read()

On 9/4/20 3:13 AM, Bean Huo wrote:
> From: Bean Huo <[email protected]>
>
>
> Bean Huo (2):
> block: use generic_file_buffered_read()
> fs: isofs: use generic_file_buffered_read()

The change is fine, but the title/commit message should reflect that
this is just a comment change. The way it currently reads, it sounds
like a functional change where something is switched over to using
generic_file_buffered_read().

--
Jens Axboe

2020-09-07 11:40:35

by Bean Huo

Subject: Re: [PATCH 0/2] use generic_file_buffered_read()

On Fri, 2020-09-04 at 10:53 -0600, Jens Axboe wrote:
> > Bean Huo (2):
> > block: use generic_file_buffered_read()
> > fs: isofs: use generic_file_buffered_read()
>
> The change is fine, but the title/commit message should reflect that
> this is just a comment change. The way it currently reads, it sounds
> like a functional change where something is switched over to using
> generic_file_buffered_read().
>

Hi Jens
Indeed, it's easy to mistake this for a functional change, but it's
actually a comment change. I have corrected them in the new patch, you
can check now.

thanks,
Bean