2020-09-04 14:24:28

by Landen Chao (趙皎宏)

Subject: [PATCH net-next v3 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531

Add devicetree binding to support the compatible mt7531 switch as used
in the MediaTek MT7531 switch.

Signed-off-by: Sean Wang <[email protected]>
Signed-off-by: Landen Chao <[email protected]>
---
Documentation/devicetree/bindings/net/dsa/mt7530.txt | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/mt7530.txt b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
index c5ed5d25f642..e22cd56d83fe 100644
--- a/Documentation/devicetree/bindings/net/dsa/mt7530.txt
+++ b/Documentation/devicetree/bindings/net/dsa/mt7530.txt
@@ -5,6 +5,7 @@ Required properties:

- compatible: may be compatible = "mediatek,mt7530"
or compatible = "mediatek,mt7621"
+ or compatible = "mediatek,mt7531"
- #address-cells: Must be 1.
- #size-cells: Must be 0.
- mediatek,mcm: Boolean; if defined, indicates that either MT7530 is the part
@@ -32,10 +33,13 @@ Required properties for the child nodes within ports container:

- reg: Port address described must be 6 for CPU port and from 0 to 5 for
user ports.
-- phy-mode: String, must be either "trgmii" or "rgmii" for port labeled
- "cpu".
+- phy-mode: String, the follow value would be acceptable for port labeled "cpu"
+ If compatible mediatek,mt7530 or mediatek,mt7621 is set,
+ must be either "trgmii" or "rgmii"
+ If compatible mediatek,mt7531 is set,
+ must be either "sgmii", "1000base-x" or "2500base-x"

-Port 5 of the switch is muxed between:
+Port 5 of mt7530 and mt7621 switch is muxed between:
1. GMAC5: GMAC5 can interface with another external MAC or PHY.
2. PHY of port 0 or port 4: PHY interfaces with an external MAC like 2nd GMAC
of the SOC. Used in many setups where port 0/4 becomes the WAN port.
--
2.17.1

2020-09-05 23:38:50

by Jakub Kicinski

Subject: Re: [PATCH net-next v3 3/6] dt-bindings: net: dsa: add new MT7531 binding to support MT7531

On Fri, 4 Sep 2020 22:21:58 +0800 Landen Chao wrote:
> @@ -32,10 +33,13 @@ Required properties for the child nodes within ports container:
>
> - reg: Port address described must be 6 for CPU port and from 0 to 5 for
> user ports.
> -- phy-mode: String, must be either "trgmii" or "rgmii" for port labeled
> - "cpu".
> +- phy-mode: String, the follow value would be acceptable for port labeled "cpu"

... the following values are acceptable for port labeled "cpu":

> + If compatible mediatek,mt7530 or mediatek,mt7621 is set,
> + must be either "trgmii" or "rgmii"
> + If compatible mediatek,mt7531 is set,
> + must be either "sgmii", "1000base-x" or "2500base-x"