2020-09-14 06:32:44

by Liu Shixin

Subject: [PATCH -next] iio: adc: palmas_gpadc: use module_platform_driver to simplify the code

module_platform_driver() makes the code simpler by eliminating
boilerplate code.

Signed-off-by: Liu Shixin <[email protected]>
---
drivers/iio/adc/palmas_gpadc.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
index 1ca6570be66a..889b88768b63 100644
--- a/drivers/iio/adc/palmas_gpadc.c
+++ b/drivers/iio/adc/palmas_gpadc.c
@@ -834,18 +834,7 @@ static struct platform_driver palmas_gpadc_driver = {
.of_match_table = of_palmas_gpadc_match_tbl,
},
};
-
-static int __init palmas_gpadc_init(void)
-{
- return platform_driver_register(&palmas_gpadc_driver);
-}
-module_init(palmas_gpadc_init);
-
-static void __exit palmas_gpadc_exit(void)
-{
- platform_driver_unregister(&palmas_gpadc_driver);
-}
-module_exit(palmas_gpadc_exit);
+module_platform_driver(palmas_gpadc_driver);

MODULE_DESCRIPTION("palmas GPADC driver");
MODULE_AUTHOR("Pradeep Goudagunta<[email protected]>");
--
2.25.1

2020-09-16 18:22:32

by Jonathan Cameron

Subject: Re: [PATCH -next] iio: adc: palmas_gpadc: use module_platform_driver to simplify the code

On Mon, 14 Sep 2020 14:54:01 +0800
Liu Shixin <[email protected]> wrote:

> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Liu Shixin <[email protected]>

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see if we missed anything.

Thanks,

Jonathan

> ---
> drivers/iio/adc/palmas_gpadc.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c
> index 1ca6570be66a..889b88768b63 100644
> --- a/drivers/iio/adc/palmas_gpadc.c
> +++ b/drivers/iio/adc/palmas_gpadc.c
> @@ -834,18 +834,7 @@ static struct platform_driver palmas_gpadc_driver = {
> .of_match_table = of_palmas_gpadc_match_tbl,
> },
> };
> -
> -static int __init palmas_gpadc_init(void)
> -{
> - return platform_driver_register(&palmas_gpadc_driver);
> -}
> -module_init(palmas_gpadc_init);
> -
> -static void __exit palmas_gpadc_exit(void)
> -{
> - platform_driver_unregister(&palmas_gpadc_driver);
> -}
> -module_exit(palmas_gpadc_exit);
> +module_platform_driver(palmas_gpadc_driver);
>
> MODULE_DESCRIPTION("palmas GPADC driver");
> MODULE_AUTHOR("Pradeep Goudagunta<[email protected]>");