2020-09-15 22:24:01

by Chris Down

Subject: Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node

Michal Hocko writes:
>On Tue 15-09-20 15:47:37, Chris Down wrote:
>> [email protected] writes:
>> > + if (signal_pending(current))
>> > + return;
>>
>> This doesn't match your patch title, please update it. :-)
>
>I have to admit I have completely missed this and I think that this
>should better be fatal_signal_pending because that would make sure that
>the userspace will not see an incomplete operation. This is a general
>practice for other bail outs as well.

Oh sorry, to be clear, I meant the patch should match the title, not the other
way around.

2020-09-16 02:40:32

by Chunxin Zang

Subject: Re: [External] Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node

On Wed, Sep 16, 2020 at 12:26 AM Chris Down <[email protected]> wrote:
>
> Michal Hocko writes:
> >On Tue 15-09-20 15:47:37, Chris Down wrote:
> >> [email protected] writes:
> >> > + if (signal_pending(current))
> >> > + return;
> >>
> >> This doesn't match your patch title, please update it. :-)
> >
> >I have to admit I have completely missed this and I think that this
> >should better be fatal_signal_pending because that would make sure that
> >the userspace will not see an incomplete operation. This is a general
> >practice for other bail outs as well.
>
> Oh sorry, to be clear, I meant the patch should match the title, not the other
> way around.

My apologies about that. In my first version of patch, it's
'fatal_signal_pending'.
But in this version, I used the wrong branch. I will update it now.

Best wishes
Chunxin