2020-09-15 19:32:10

by Martin Blumenstingl

Subject: [PATCH] iio: adc: meson-saradc: Make the of_device_id array style consistent

Use only one line for the closing bracket of the last entry and the
opening bracket for the next one to keep the style across the whole
array consistent. Also add a "sentinel" comment to the last entry and
remove the comma to ensure that there won't be any entry after it.
No functional changes.

Signed-off-by: Martin Blumenstingl <[email protected]>
---
drivers/iio/adc/meson_saradc.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
index 95bd187de1cb..e03988698755 100644
--- a/drivers/iio/adc/meson_saradc.c
+++ b/drivers/iio/adc/meson_saradc.c
@@ -1150,16 +1150,13 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
{
.compatible = "amlogic,meson8-saradc",
.data = &meson_sar_adc_meson8_data,
- },
- {
+ }, {
.compatible = "amlogic,meson8b-saradc",
.data = &meson_sar_adc_meson8b_data,
- },
- {
+ }, {
.compatible = "amlogic,meson8m2-saradc",
.data = &meson_sar_adc_meson8m2_data,
- },
- {
+ }, {
.compatible = "amlogic,meson-gxbb-saradc",
.data = &meson_sar_adc_gxbb_data,
}, {
@@ -1175,7 +1172,7 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
.compatible = "amlogic,meson-g12a-saradc",
.data = &meson_sar_adc_g12a_data,
},
- {},
+ { /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, meson_sar_adc_of_match);

--
2.28.0

2020-09-16 18:20:05

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: meson-saradc: Make the of_device_id array style consistent

On Tue, 15 Sep 2020 21:26:21 +0200
Martin Blumenstingl <[email protected]> wrote:

> Use only one line for the closing bracket of the last entry and the
> opening bracket for the next one to keep the style across the whole
> array consistent. Also add a "sentinel" comment to the last entry and
> remove the comma to ensure that there won't be any entry after it.
> No functional changes.
>
> Signed-off-by: Martin Blumenstingl <[email protected]>

Applied,

Thanks,

Jonathan

> ---
> drivers/iio/adc/meson_saradc.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 95bd187de1cb..e03988698755 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -1150,16 +1150,13 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
> {
> .compatible = "amlogic,meson8-saradc",
> .data = &meson_sar_adc_meson8_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson8b-saradc",
> .data = &meson_sar_adc_meson8b_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson8m2-saradc",
> .data = &meson_sar_adc_meson8m2_data,
> - },
> - {
> + }, {
> .compatible = "amlogic,meson-gxbb-saradc",
> .data = &meson_sar_adc_gxbb_data,
> }, {
> @@ -1175,7 +1172,7 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
> .compatible = "amlogic,meson-g12a-saradc",
> .data = &meson_sar_adc_g12a_data,
> },
> - {},
> + { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, meson_sar_adc_of_match);
>